Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ESM artifacts to build outputs #17453

Closed
wants to merge 49 commits into from
Closed
Show file tree
Hide file tree
Changes from 29 commits
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
5f6fbf9
add esm artifacts to build outputs
darthtrevino Nov 25, 2019
0561663
remove esm from reconciler libraries for now
darthtrevino Nov 25, 2019
fe8021e
run prettier
darthtrevino Nov 25, 2019
094113b
add esm folders to pkg.files
darthtrevino Nov 25, 2019
6a82a9a
remove the ampproject closure-compiler plugin, skip minifying of ESM …
darthtrevino Nov 25, 2019
00684f4
move forbid-fbjs plugin to plugins folder
darthtrevino Nov 26, 2019
1f6c0f8
build: refactor build.js into a set of packages
darthtrevino Nov 27, 2019
7f88094
run prettier
darthtrevino Nov 27, 2019
afb1293
build: add a doc note about what the transform-object-assign-require …
darthtrevino Nov 27, 2019
57364cc
update .gitignore to ignore top-level build folder
darthtrevino Nov 27, 2019
4618a45
add esm bundle generation, move some argvs to predicates
darthtrevino Nov 27, 2019
ac94f10
add "module" fields to esm-supporting packages
darthtrevino Nov 27, 2019
67e2c7f
move more predicates to predicates file
darthtrevino Nov 28, 2019
10eee7c
pass bundleType to isFBBundle
darthtrevino Nov 28, 2019
866309f
predicate updates
darthtrevino Nov 28, 2019
dea8c04
change bundles to be a let variable
darthtrevino Nov 28, 2019
4558905
remove console.log statement
darthtrevino Nov 28, 2019
4e7f9ac
add index.mjs to pkg.json files arrays
darthtrevino Nov 28, 2019
3274958
remove main and module fields from react-interactions
darthtrevino Nov 28, 2019
f89c7ca
remove main and module fields from react-refresh
darthtrevino Nov 28, 2019
a8cdedf
update rollup to get better output of esm module exports
darthtrevino Nov 28, 2019
97e4414
silence circular dependency warnings
darthtrevino Nov 28, 2019
68c234b
run prettier
darthtrevino Nov 28, 2019
3684219
add globalThis global to umd build-lint
darthtrevino Nov 28, 2019
2b7d9d3
use terser to minify esm as a stopgop
darthtrevino Nov 28, 2019
4285307
remove isminifyable from predicates export list
darthtrevino Nov 28, 2019
4443750
add script to verify main/module file existence
darthtrevino Nov 28, 2019
1970c74
add a check to verify package structure
darthtrevino Nov 28, 2019
ec52686
yaml update
darthtrevino Nov 28, 2019
f387926
Use the conditionl-exports based dual-entry model described in the no…
darthtrevino Nov 28, 2019
45b594e
update package-check script to verify require() and import() on packa…
darthtrevino Nov 28, 2019
7f08a44
remove exports object from packages in-situ - it interferes with the …
darthtrevino Nov 28, 2019
4b33772
wire exports map into packages as a build step
darthtrevino Nov 28, 2019
15b0128
move exports map to package.json in src/ folder
darthtrevino Nov 30, 2019
28058ef
improve package-check script
darthtrevino Nov 30, 2019
f4e19ec
add ignored package map to package-check
darthtrevino Nov 30, 2019
4158093
remove esm entry generation, add mjs to sceduler package
darthtrevino Nov 30, 2019
c3692b8
add npm/<x>.mjs files to packages with esm support
darthtrevino Dec 1, 2019
287353b
remove isEsmEntryGenerator predicate
darthtrevino Dec 1, 2019
e8ab37d
add esm/ folder to react-debug-tools
darthtrevino Dec 1, 2019
ee65e0f
Add github action to verify package structure
darthtrevino Dec 1, 2019
7965363
remove test_package_structure from circleci config
darthtrevino Dec 1, 2019
333d836
incorporate custom babel plugin from pull #13356 to replace legacy mode
darthtrevino Dec 1, 2019
49b0a01
emojify the package-check script
darthtrevino Dec 1, 2019
fe0c796
run prettier
darthtrevino Dec 1, 2019
d1ba800
update babel-transform path
darthtrevino Dec 1, 2019
f971c35
update remove-getters tests
darthtrevino Dec 1, 2019
9df7125
simplify check_package_structure GH action
darthtrevino Dec 1, 2019
87594d7
cache install step
darthtrevino Dec 1, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,19 @@ jobs:
RELEASE_CHANNEL: stable
command: yarn test-build --maxWorkers=2

test_package_structure:
docker: *docker
environment: *environment
steps:
- checkout
- attach_workspace: *attach_workspace
- *restore_yarn_cache
- *run_yarn
- run:
environment:
RELEASE_CHANNEL: stable
command: yarn test-package-structure

test_build_experimental:
docker: *docker
environment: *environment
Expand Down Expand Up @@ -371,6 +384,9 @@ workflows:
- test_build:
requires:
- build
- test_package_structure:
requires:
- build
- test_build_prod:
requires:
- build
Expand Down
4 changes: 2 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ scripts/flow/*/.flowconfig
.grunt
_SpecRunner.html
__benchmarks__
build/
/build
remote-repo/
coverage/
.module-cache
Expand All @@ -32,4 +32,4 @@ packages/react-devtools-extensions/firefox/*.xpi
packages/react-devtools-extensions/firefox/*.pem
packages/react-devtools-extensions/shared/build
packages/react-devtools-inline/dist
packages/react-devtools-shell/dist
packages/react-devtools-shell/dist
18 changes: 10 additions & 8 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -76,13 +76,14 @@
"random-seed": "^0.3.0",
"react-lifecycles-compat": "^3.0.2",
"rimraf": "^2.6.1",
"rollup": "^0.52.1",
"rollup-plugin-babel": "^4.0.1",
"rollup-plugin-commonjs": "^8.2.6",
"rollup-plugin-node-resolve": "^2.1.1",
"rollup-plugin-prettier": "^0.3.0",
"rollup-plugin-replace": "^2.0.0",
"rollup-plugin-strip-banner": "^0.2.0",
"rollup": "^1.27.5",
"rollup-plugin-babel": "^4.3.3",
"rollup-plugin-commonjs": "^10.1.0",
"rollup-plugin-node-resolve": "^5.2.0",
"rollup-plugin-prettier": "^0.6.0",
"rollup-plugin-replace": "^2.2.0",
"rollup-plugin-strip-banner": "^1.0.0",
"rollup-plugin-terser": "^5.1.2",
"semver": "^5.5.0",
"targz": "^1.0.1",
"through2": "^2.0.0",
Expand All @@ -97,7 +98,7 @@
"testRegex": "/scripts/jest/dont-run-jest-directly\\.js$"
},
"scripts": {
"build": "node ./scripts/rollup/build.js",
"build": "node ./scripts/rollup/build",
"linc": "node ./scripts/tasks/linc.js",
"lint": "node ./scripts/tasks/eslint.js",
"lint-build": "node ./scripts/rollup/validate/index.js",
Expand All @@ -112,6 +113,7 @@
"test-build": "cross-env NODE_ENV=development jest --config ./scripts/jest/config.build.js",
"test-build-prod": "cross-env NODE_ENV=production jest --config ./scripts/jest/config.build.js",
"test-build-devtools": "cross-env NODE_ENV=development jest --config ./scripts/jest/config.build-devtools.js",
"test-package-structure": "node ./scripts/tasks/package-check.js",
"debug-test-build-devtools": "cross-env NODE_ENV=development node --inspect-brk node_modules/.bin/jest --config ./scripts/jest/config.build-devtools.js",
"test-dom-fixture": "cd fixtures/dom && yarn && yarn prestart && yarn test",
"flow": "node ./scripts/tasks/flow.js",
Expand Down
5 changes: 3 additions & 2 deletions packages/babel-plugin-react-jsx/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,14 @@
"main": "index.js",
"dependencies": {
"esutils": "^2.0.0"

},
"files": [
"README.md",
"index.js",
"build-info.json",
"cjs/",
"umd/"
"umd/",
"esm/"
]
}
6 changes: 5 additions & 1 deletion packages/create-subscription/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
"name": "create-subscription",
"description": "utility for subscribing to external data sources inside React components",
"version": "16.12.0",
"main": "index.js",
"module": "index.mjs",
darthtrevino marked this conversation as resolved.
Show resolved Hide resolved
"repository": {
"type": "git",
"url": "https://github.com/facebook/react.git",
Expand All @@ -12,7 +14,9 @@
"README.md",
"build-info.json",
"index.js",
"cjs/"
"index.mjs",
"cjs/",
"esm/"
],
"peerDependencies": {
"react": "^16.3.0"
Expand Down
6 changes: 5 additions & 1 deletion packages/eslint-plugin-react-hooks/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,16 @@
"url": "https://github.com/facebook/react.git",
"directory": "packages/eslint-plugin-react-hooks"
},
"main": "index.js",
"module": "index.mjs",
"files": [
"LICENSE",
"README.md",
"build-info.json",
"index.js",
"cjs"
"index.mjs",
"cjs/",
"esm/"
],
"keywords": [
"eslint",
Expand Down
5 changes: 4 additions & 1 deletion packages/jest-mock-scheduler/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"version": "0.1.0",
"description": "Jest matchers and utilities for testing the scheduler package.",
"main": "index.js",
"module": "index.mjs",
"repository": {
"type" : "git",
"url" : "https://github.com/facebook/react.git",
Expand All @@ -27,6 +28,8 @@
"README.md",
"build-info.json",
"index.js",
"cjs/"
"index.mjs",
"cjs/",
"esm/"
]
}
5 changes: 4 additions & 1 deletion packages/jest-react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"version": "0.10.0",
"description": "Jest matchers and utilities for testing React components.",
"main": "index.js",
"module": "index.mjs",
"repository": {
"type": "git",
"url": "https://github.com/facebook/react.git",
Expand All @@ -28,6 +29,8 @@
"README.md",
"build-info.json",
"index.js",
"cjs/"
"index.mjs",
"cjs/",
"esm/"
]
}
3 changes: 3 additions & 0 deletions packages/react-art/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"description": "React ART is a JavaScript library for drawing vector graphics using React. It provides declarative and reactive bindings to the ART library. Using the same declarative API you can render the output to either Canvas, SVG or VML (IE8).",
"version": "16.12.0",
"main": "index.js",
"module": "index.mjs",
"repository": {
"type": "git",
"url": "https://github.com/facebook/react.git",
Expand Down Expand Up @@ -37,7 +38,9 @@
"README.md",
"build-info.json",
"index.js",
"index.mjs",
"cjs/",
"esm/",
"umd/",
"Circle.js",
"Rectangle.js",
Expand Down
6 changes: 5 additions & 1 deletion packages/react-cache/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
"name": "react-cache",
"description": "A basic cache for React applications",
"version": "2.0.0-alpha.0",
"main": "index.js",
"module": "index.mjs",
"repository": {
"type" : "git",
"url" : "https://github.com/facebook/react.git",
Expand All @@ -13,8 +15,10 @@
"README.md",
"build-info.json",
"index.js",
"index.mjs",
"cjs/",
"umd/"
"umd/",
"esm/"
],
"peerDependencies": {
"react": "^16.3.0-alpha.1"
Expand Down
5 changes: 4 additions & 1 deletion packages/react-debug-tools/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,12 @@
"README.md",
"build-info.json",
"index.js",
"cjs/"
"index.mjs",
"cjs/",
"esm/"
],
"main": "index.js",
"module": "index.mjs",
"repository": {
"type" : "git",
"url" : "https://github.com/facebook/react.git",
Expand Down
5 changes: 4 additions & 1 deletion packages/react-dom/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"version": "16.12.0",
"description": "React package for working with the DOM.",
"main": "index.js",
"module": "index.mjs",
"repository": {
"type": "git",
"url": "https://github.com/facebook/react.git",
Expand Down Expand Up @@ -30,6 +31,7 @@
"README.md",
"build-info.json",
"index.js",
"index.mjs",
"profiling.js",
"server.js",
"server.browser.js",
Expand All @@ -41,7 +43,8 @@
"unstable-fizz.node.js",
"unstable-native-dependencies.js",
"cjs/",
"umd/"
"umd/",
"esm/"
],
"browser": {
"./server.js": "./server.browser.js",
Expand Down
5 changes: 4 additions & 1 deletion packages/react-flight-dom-webpack/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,16 +13,19 @@
"LICENSE",
"README.md",
"index.js",
"index.mjs",
"server.js",
"server.browser.js",
"server.node.js",
"cjs/",
"umd/"
"umd/",
"esm/"
],
"browser": {
"./server.js": "./server.browser.js"
},
"main": "index.js",
"module": "index.mjs",
"repository": {
"type" : "git",
"url" : "https://github.com/facebook/react.git",
Expand Down
4 changes: 3 additions & 1 deletion packages/react-flight/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,9 @@
"LICENSE",
"README.md",
"index.js",
"cjs/"
"index.mjs",
"cjs/",
"esm/"
],
"main": "index.js",
"repository": {
Expand Down
4 changes: 2 additions & 2 deletions packages/react-interactions/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@
"events/tap.js",
"build-info.json",
"cjs/",
"umd/"
"umd/",
"esm/"
],
"main": "index.js",
"repository": {
"type": "git",
"url": "https://github.com/facebook/react.git",
Expand Down
5 changes: 4 additions & 1 deletion packages/react-is/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"version": "16.12.0",
"description": "Brand checking of React Elements.",
"main": "index.js",
"module": "index.mjs",
"repository": {
"type": "git",
"url": "https://github.com/facebook/react.git",
Expand All @@ -21,7 +22,9 @@
"README.md",
"build-info.json",
"index.js",
"index.mjs",
"cjs/",
"umd/"
"umd/",
"esm/"
]
}
5 changes: 4 additions & 1 deletion packages/react-noop-renderer/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"private": true,
"description": "React package for testing the Fiber, Fizz and Flight reconcilers.",
"main": "index.js",
"module": "index.mjs",
"repository": {
"type" : "git",
"url" : "https://github.com/facebook/react.git",
Expand All @@ -26,10 +27,12 @@
"README.md",
"build-info.json",
"index.js",
"index.mjs",
"persistent.js",
"server.js",
"flight-client.js",
"flight-server.js",
"cjs/"
"cjs/",
"esm/"
]
}
4 changes: 2 additions & 2 deletions packages/react-refresh/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@
"runtime.js",
"build-info.json",
"cjs/",
"umd/"
"umd/",
"esm/"
],
"main": "index.js",
"repository": {
"type": "git",
"url": "https://github.com/facebook/react.git",
Expand Down
3 changes: 2 additions & 1 deletion packages/react-server/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@
"README.md",
"index.js",
"flight.js",
"cjs/"
"cjs/",
"esm/"
],
"main": "index.js",
"repository": {
Expand Down
5 changes: 4 additions & 1 deletion packages/react-test-renderer/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"version": "16.12.0",
"description": "React package for snapshot testing.",
"main": "index.js",
"module": "index.mjs",
"repository": {
"type": "git",
"url": "https://github.com/facebook/react.git",
Expand Down Expand Up @@ -32,8 +33,10 @@
"README.md",
"build-info.json",
"index.js",
"index.mjs",
"shallow.js",
"cjs/",
"umd/"
"umd/",
"esm/"
]
}
5 changes: 4 additions & 1 deletion packages/react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,13 @@
"README.md",
"build-info.json",
"index.js",
"index.mjs",
"cjs/",
"umd/"
"umd/",
"esm/"
],
"main": "index.js",
"module": "index.mjs",
"repository": {
"type": "git",
"url": "https://github.com/facebook/react.git",
Expand Down
Loading