Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize update queue object on mount #17560

Merged
merged 2 commits into from
Dec 11, 2019

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Dec 9, 2019

Follow-up to b617db3

Instead of lazily initializing update queue objects on the first update, class and host root queues are created on mount. This simplifies the logic for appending new updates and matches what we do for hooks.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 9, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7768843:

Sandbox Source
elastic-stonebraker-yxmhm Configuration

@sizebot
Copy link

sizebot commented Dec 9, 2019

Details of bundled changes.

Comparing: e039e69...7768843

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.profiling.min.js -0.5% -0.0% 123.69 KB 123.07 KB 38.81 KB 38.81 KB NODE_PROFILING
react-dom-server.browser.development.js 0.0% 0.0% 140.67 KB 140.67 KB 36.94 KB 36.94 KB UMD_DEV
react-dom-server.browser.production.min.js 0.0% 0.0% 20.39 KB 20.39 KB 7.48 KB 7.48 KB UMD_PROD
react-dom-test-utils.development.js 0.0% 0.0% 56.18 KB 56.18 KB 15.54 KB 15.55 KB UMD_DEV
react-dom-unstable-fizz.browser.development.js 0.0% +0.1% 3.88 KB 3.88 KB 1.55 KB 1.55 KB UMD_DEV
react-dom-test-utils.production.min.js 0.0% 🔺+0.1% 11.18 KB 11.18 KB 4.15 KB 4.15 KB UMD_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.3% 1.21 KB 1.21 KB 709 B 711 B UMD_PROD
ReactDOMServer-dev.js 0.0% 0.0% 140.21 KB 140.21 KB 35.48 KB 35.48 KB FB_WWW_DEV
react-dom-test-utils.development.js 0.0% 0.0% 54.45 KB 54.45 KB 15.21 KB 15.21 KB NODE_DEV
react-dom-unstable-fizz.browser.development.js 0.0% +0.1% 3.71 KB 3.71 KB 1.5 KB 1.5 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% 0.0% 10.95 KB 10.95 KB 4.09 KB 4.09 KB NODE_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.2% 1.05 KB 1.05 KB 641 B 642 B NODE_PROD
react-dom.development.js -0.3% -0.1% 955.66 KB 952.97 KB 216.06 KB 215.77 KB UMD_DEV
react-dom.production.min.js -0.5% -0.1% 119.74 KB 119.11 KB 38.46 KB 38.43 KB UMD_PROD
react-dom.profiling.min.js -0.5% -0.1% 123.42 KB 122.8 KB 39.56 KB 39.53 KB UMD_PROFILING
react-dom.development.js -0.3% -0.1% 949.73 KB 947.04 KB 214.48 KB 214.2 KB NODE_DEV
react-dom-server.node.development.js 0.0% 0.0% 137.71 KB 137.71 KB 36.17 KB 36.17 KB NODE_DEV
react-dom.production.min.js -0.5% -0.1% 119.88 KB 119.26 KB 37.79 KB 37.76 KB NODE_PROD
react-dom-server.node.production.min.js 0.0% 0.0% 20.72 KB 20.72 KB 7.61 KB 7.61 KB NODE_PROD
react-dom-server.browser.development.js 0.0% 0.0% 136.6 KB 136.6 KB 35.94 KB 35.94 KB NODE_DEV
react-dom-server.browser.production.min.js 0.0% 0.0% 20.31 KB 20.31 KB 7.46 KB 7.46 KB NODE_PROD
react-dom-unstable-native-dependencies.development.js 0.0% 0.0% 60.1 KB 60.1 KB 15.78 KB 15.78 KB UMD_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% 🔺+0.1% 10.73 KB 10.73 KB 3.67 KB 3.68 KB UMD_PROD
ReactDOM-dev.js -0.3% -0.2% 978.24 KB 975.19 KB 217.02 KB 216.68 KB FB_WWW_DEV
ReactDOM-prod.js -0.1% 🔺+0.1% 402.25 KB 401.68 KB 73.07 KB 73.14 KB FB_WWW_PROD
react-dom-unstable-native-dependencies.development.js 0.0% 0.0% 59.77 KB 59.77 KB 15.65 KB 15.65 KB NODE_DEV
react-dom-unstable-fizz.node.development.js 0.0% +0.1% 4.42 KB 4.42 KB 1.65 KB 1.65 KB NODE_DEV
ReactDOM-profiling.js -0.1% +0.2% 404.04 KB 403.48 KB 74.01 KB 74.14 KB FB_WWW_PROFILING
react-dom-unstable-native-dependencies.production.min.js 0.0% 🔺+0.1% 10.48 KB 10.48 KB 3.57 KB 3.58 KB NODE_PROD
react-dom-unstable-fizz.node.production.min.js 0.0% 🔺+0.3% 1.21 KB 1.21 KB 696 B 698 B NODE_PROD

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactFabric-prod.js -0.3% 🔺+0.2% 268.96 KB 268.19 KB 46.22 KB 46.31 KB RN_FB_PROD
ReactNativeRenderer-dev.js -0.4% -0.2% 750.39 KB 747.34 KB 158.89 KB 158.54 KB RN_OSS_DEV
ReactFabric-profiling.js -0.3% +0.2% 279.07 KB 278.29 KB 48.06 KB 48.15 KB RN_FB_PROFILING
ReactNativeRenderer-prod.js -0.3% 🔺+0.2% 277.3 KB 276.53 KB 47.61 KB 47.68 KB RN_FB_PROD
ReactNativeRenderer-profiling.js -0.3% +0.2% 286.23 KB 285.46 KB 49.33 KB 49.41 KB RN_FB_PROFILING
ReactFabric-dev.js -0.4% -0.2% 755.83 KB 752.78 KB 159.73 KB 159.38 KB RN_OSS_DEV
ReactFabric-prod.js -0.3% 🔺+0.2% 268.61 KB 267.84 KB 46.14 KB 46.23 KB RN_OSS_PROD
ReactFabric-profiling.js -0.3% +0.2% 278.72 KB 277.95 KB 47.99 KB 48.08 KB RN_OSS_PROFILING
ReactFabric-dev.js -0.4% -0.2% 756.01 KB 752.96 KB 159.81 KB 159.46 KB RN_FB_DEV
ReactNativeRenderer-prod.js -0.3% 🔺+0.2% 276.91 KB 276.14 KB 47.54 KB 47.61 KB RN_OSS_PROD
ReactNativeRenderer-profiling.js -0.3% +0.2% 285.85 KB 285.08 KB 49.26 KB 49.34 KB RN_OSS_PROFILING
ReactNativeRenderer-dev.js -0.4% -0.2% 750.57 KB 747.52 KB 158.97 KB 158.62 KB RN_FB_DEV

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-test-renderer.development.js -0.4% -0.2% 619.16 KB 616.47 KB 132.02 KB 131.74 KB UMD_DEV
react-test-renderer.production.min.js -0.9% -0.2% 71.85 KB 71.22 KB 21.95 KB 21.92 KB UMD_PROD
ReactTestRenderer-dev.js -0.5% -0.3% 629.94 KB 626.89 KB 131.2 KB 130.84 KB FB_WWW_DEV
react-test-renderer-shallow.development.js 0.0% 0.0% 39.15 KB 39.15 KB 10.01 KB 10.01 KB UMD_DEV
react-test-renderer-shallow.production.min.js 0.0% 🔺+0.1% 11.6 KB 11.6 KB 3.58 KB 3.58 KB UMD_PROD
react-test-renderer-shallow.development.js 0.0% 0.0% 33.1 KB 33.1 KB 8.53 KB 8.54 KB NODE_DEV
react-test-renderer-shallow.production.min.js 0.0% 0.0% 11.73 KB 11.73 KB 3.69 KB 3.69 KB NODE_PROD
react-test-renderer.development.js -0.4% -0.2% 614.43 KB 611.74 KB 130.84 KB 130.55 KB NODE_DEV
react-test-renderer.production.min.js -0.9% -0.2% 71.54 KB 70.93 KB 21.59 KB 21.55 KB NODE_PROD

react-noop-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-noop-renderer.development.js +1.3% +1.2% 35 KB 35.45 KB 8 KB 8.1 KB NODE_DEV
react-noop-renderer-flight-client.development.js 0.0% +0.3% 1.63 KB 1.63 KB 778 B 780 B NODE_DEV
react-noop-renderer.production.min.js 🔺+1.1% 🔺+1.3% 11.85 KB 11.97 KB 3.78 KB 3.83 KB NODE_PROD
react-noop-renderer-flight-client.production.min.js 0.0% 🔺+0.2% 574 B 574 B 423 B 424 B NODE_PROD
react-noop-renderer-flight-server.development.js 0.0% +0.2% 2.18 KB 2.18 KB 961 B 963 B NODE_DEV
react-noop-renderer-flight-server.production.min.js 0.0% 🔺+0.2% 1007 B 1007 B 567 B 568 B NODE_PROD
react-noop-renderer-server.development.js 0.0% +0.1% 1.98 KB 1.98 KB 906 B 907 B NODE_DEV
react-noop-renderer-server.production.min.js 0.0% 🔺+0.2% 901 B 901 B 513 B 514 B NODE_PROD
react-noop-renderer-persistent.development.js +1.3% +1.2% 35.11 KB 35.57 KB 8.02 KB 8.12 KB NODE_DEV
react-noop-renderer-persistent.production.min.js 🔺+1.1% 🔺+1.3% 11.87 KB 11.99 KB 3.79 KB 3.84 KB NODE_PROD

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactART-dev.js -0.5% -0.3% 618.27 KB 615.22 KB 128.63 KB 128.28 KB FB_WWW_DEV
ReactART-prod.js -0.3% 🔺+0.1% 235.6 KB 234.87 KB 39.88 KB 39.94 KB FB_WWW_PROD
react-art.development.js -0.4% -0.2% 674.24 KB 671.54 KB 146.34 KB 146.06 KB UMD_DEV
react-art.production.min.js -0.6% -0.2% 106.81 KB 106.19 KB 32.43 KB 32.36 KB UMD_PROD
react-art.development.js -0.4% -0.2% 604.88 KB 602.19 KB 128.95 KB 128.66 KB NODE_DEV
react-art.production.min.js -0.9% 0.0% 71.78 KB 71.16 KB 21.49 KB 21.5 KB NODE_PROD

react-reconciler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-reconciler-persistent.development.js -0.4% -0.2% 603.39 KB 600.69 KB 127.04 KB 126.75 KB NODE_DEV
react-reconciler-persistent.production.min.js -0.9% -0.1% 72.59 KB 71.97 KB 21.33 KB 21.31 KB NODE_PROD
react-reconciler-reflection.production.min.js 0.0% 🔺+0.1% 2.86 KB 2.86 KB 1.24 KB 1.24 KB NODE_PROD
react-reconciler.development.js -0.4% -0.2% 605.92 KB 603.22 KB 128.14 KB 127.84 KB NODE_DEV
react-reconciler.production.min.js -0.8% -0.1% 74.81 KB 74.18 KB 21.9 KB 21.87 KB NODE_PROD

ReactDOM: size: 0.0%, gzip: 0.0%

Size changes (experimental)

Generated by 🚫 dangerJS against 7768843

acdlite and others added 2 commits December 9, 2019 15:19
Fixes a bug related to rebasing updates. Once an update has committed,
it should never un-commit, even if interrupted by a higher priority
update. The fix includes a refactor of how update queues work.

This commit is a combination of two PRs:

- facebook#17483 by @sebmarkbage refactors the hook update queue
- facebook#17510 by @acdlite refactors the class and root update queue

Landing one without the other would cause state updates to sometimes be
inconsistent across components, so I've combined them into a single
commit in case they need to be reverted.

Co-authored-by: Sebastian Markbåge <sema@fb.com>
Co-authored-by: Andrew Clark <git@andrewclark.io>
Instead of lazily initializing update queue objects on the first update,
class and host root queues are created on mount. This simplifies the
logic for appending new updates and matches what we do for hooks.
@sizebot
Copy link

sizebot commented Dec 9, 2019

Details of bundled changes.

Comparing: e039e69...7768843

react-reconciler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-reconciler.production.min.js -0.9% -0.1% 72.57 KB 71.94 KB 21.32 KB 21.29 KB NODE_PROD
react-reconciler-reflection.production.min.js 0.0% 🔺+0.2% 2.85 KB 2.85 KB 1.24 KB 1.24 KB NODE_PROD
react-reconciler-persistent.development.js -0.4% -0.2% 603.38 KB 600.68 KB 127.03 KB 126.74 KB NODE_DEV
react-reconciler-persistent.production.min.js -0.9% -0.1% 72.58 KB 71.95 KB 21.32 KB 21.3 KB NODE_PROD
react-reconciler.development.js -0.4% -0.2% 605.91 KB 603.21 KB 128.14 KB 127.84 KB NODE_DEV
react-reconciler-reflection.development.js 0.0% 0.0% 19.08 KB 19.08 KB 6.23 KB 6.23 KB NODE_DEV

react-noop-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-noop-renderer.production.min.js 🔺+1.1% 🔺+1.3% 11.83 KB 11.96 KB 3.77 KB 3.82 KB NODE_PROD
react-noop-renderer-persistent.development.js +1.3% +1.2% 35.1 KB 35.56 KB 8.01 KB 8.11 KB NODE_DEV
react-noop-renderer-persistent.production.min.js 🔺+1.1% 🔺+1.3% 11.85 KB 11.98 KB 3.78 KB 3.83 KB NODE_PROD
react-noop-renderer-flight-server.development.js 0.0% +0.2% 2.17 KB 2.17 KB 952 B 954 B NODE_DEV
react-noop-renderer-flight-server.production.min.js 0.0% 🔺+0.2% 994 B 994 B 557 B 558 B NODE_PROD
react-noop-renderer.development.js +1.3% +1.2% 34.98 KB 35.44 KB 8 KB 8.1 KB NODE_DEV
react-noop-renderer-server.development.js 0.0% +0.1% 1.97 KB 1.97 KB 898 B 899 B NODE_DEV
react-noop-renderer-server.production.min.js 0.0% 🔺+0.4% 888 B 888 B 503 B 505 B NODE_PROD
react-noop-renderer-flight-client.development.js 0.0% +0.3% 1.62 KB 1.62 KB 771 B 773 B NODE_DEV
react-noop-renderer-flight-client.production.min.js 0.0% 🔺+0.5% 561 B 561 B 414 B 416 B NODE_PROD

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom-unstable-native-dependencies.production.min.js 0.0% 🔺+0.1% 10.46 KB 10.46 KB 3.56 KB 3.57 KB NODE_PROD
react-dom-server.browser.development.js 0.0% 0.0% 136.58 KB 136.58 KB 35.94 KB 35.94 KB NODE_DEV
react-dom.development.js -0.3% -0.1% 955.64 KB 952.95 KB 216.03 KB 215.75 KB UMD_DEV
react-dom-server.browser.production.min.js 0.0% 0.0% 19.85 KB 19.85 KB 7.38 KB 7.38 KB NODE_PROD
react-dom-unstable-fizz.browser.development.js 0.0% +0.2% 3.87 KB 3.87 KB 1.54 KB 1.54 KB UMD_DEV
react-dom.production.min.js -0.5% -0.1% 116.39 KB 115.77 KB 37.45 KB 37.43 KB UMD_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.3% 1.2 KB 1.2 KB 701 B 703 B UMD_PROD
react-dom.profiling.min.js -0.5% -0.1% 119.96 KB 119.33 KB 38.57 KB 38.53 KB UMD_PROFILING
react-dom.development.js -0.3% -0.1% 949.71 KB 947.01 KB 214.46 KB 214.17 KB NODE_DEV
react-dom-unstable-fizz.browser.development.js 0.0% +0.1% 3.7 KB 3.7 KB 1.49 KB 1.5 KB NODE_DEV
react-dom.production.min.js -0.5% -0.1% 116.5 KB 115.88 KB 36.86 KB 36.83 KB NODE_PROD
react-dom-unstable-native-dependencies.development.js 0.0% 0.0% 60.08 KB 60.08 KB 15.77 KB 15.77 KB UMD_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.2% 1.04 KB 1.04 KB 633 B 634 B NODE_PROD
react-dom.profiling.min.js -0.5% -0.1% 120.19 KB 119.57 KB 37.84 KB 37.82 KB NODE_PROFILING
react-dom-unstable-native-dependencies.production.min.js 0.0% 🔺+0.1% 10.72 KB 10.72 KB 3.66 KB 3.67 KB UMD_PROD
react-dom-unstable-native-dependencies.development.js 0.0% 0.0% 59.76 KB 59.76 KB 15.64 KB 15.64 KB NODE_DEV
react-dom-server.node.development.js 0.0% 0.0% 137.69 KB 137.69 KB 36.16 KB 36.16 KB NODE_DEV
react-dom-test-utils.development.js 0.0% 0.0% 56.17 KB 56.17 KB 15.54 KB 15.54 KB UMD_DEV
react-dom-server.node.production.min.js 0.0% 0.0% 20.26 KB 20.26 KB 7.53 KB 7.53 KB NODE_PROD
react-dom-test-utils.production.min.js 0.0% 🔺+0.1% 11.17 KB 11.17 KB 4.14 KB 4.14 KB UMD_PROD
react-dom-test-utils.development.js 0.0% 0.0% 54.44 KB 54.44 KB 15.21 KB 15.21 KB NODE_DEV
react-dom-unstable-fizz.node.development.js 0.0% +0.1% 4.4 KB 4.4 KB 1.64 KB 1.64 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% 0.0% 10.94 KB 10.94 KB 4.08 KB 4.08 KB NODE_PROD
react-dom-server.browser.development.js 0.0% 0.0% 140.64 KB 140.64 KB 36.94 KB 36.94 KB UMD_DEV
react-dom-unstable-fizz.node.production.min.js 0.0% 🔺+0.3% 1.2 KB 1.2 KB 688 B 690 B NODE_PROD
react-dom-server.browser.production.min.js 0.0% 0.0% 19.93 KB 19.93 KB 7.38 KB 7.39 KB UMD_PROD

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-art.development.js -0.4% -0.2% 674.22 KB 671.51 KB 146.34 KB 146.06 KB UMD_DEV
react-art.production.min.js -0.6% 0.0% 104.79 KB 104.17 KB 31.83 KB 31.84 KB UMD_PROD
react-art.development.js -0.4% -0.2% 604.86 KB 602.16 KB 128.94 KB 128.66 KB NODE_DEV
react-art.production.min.js -0.9% -0.2% 69.8 KB 69.18 KB 21.01 KB 20.98 KB NODE_PROD

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-test-renderer.development.js -0.4% -0.2% 619.14 KB 616.44 KB 132.01 KB 131.73 KB UMD_DEV
react-test-renderer.production.min.js -0.9% -0.2% 71.82 KB 71.19 KB 21.94 KB 21.9 KB UMD_PROD
react-test-renderer.development.js -0.4% -0.2% 614.41 KB 611.71 KB 130.83 KB 130.54 KB NODE_DEV
react-test-renderer.production.min.js -0.9% -0.2% 71.52 KB 70.9 KB 21.57 KB 21.54 KB NODE_PROD
react-test-renderer-shallow.development.js 0.0% 0.0% 39.13 KB 39.13 KB 10 KB 10 KB UMD_DEV
react-test-renderer-shallow.production.min.js 0.0% 🔺+0.1% 11.58 KB 11.58 KB 3.57 KB 3.58 KB UMD_PROD
react-test-renderer-shallow.development.js 0.0% 0.0% 33.09 KB 33.09 KB 8.53 KB 8.53 KB NODE_DEV
react-test-renderer-shallow.production.min.js 0.0% 🔺+0.1% 11.72 KB 11.72 KB 3.68 KB 3.68 KB NODE_PROD

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactNativeRenderer-dev.js -0.4% -0.2% 750.55 KB 747.5 KB 158.96 KB 158.62 KB RN_FB_DEV
ReactNativeRenderer-prod.js -0.3% 🔺+0.2% 277.29 KB 276.52 KB 47.6 KB 47.68 KB RN_FB_PROD
ReactNativeRenderer-profiling.js -0.3% +0.2% 286.22 KB 285.45 KB 49.32 KB 49.4 KB RN_FB_PROFILING
ReactFabric-dev.js -0.4% -0.2% 756 KB 752.95 KB 159.8 KB 159.46 KB RN_FB_DEV
ReactFabric-prod.js -0.3% 🔺+0.2% 268.95 KB 268.18 KB 46.21 KB 46.3 KB RN_FB_PROD
ReactFabric-profiling.js -0.3% +0.2% 279.05 KB 278.28 KB 48.05 KB 48.14 KB RN_FB_PROFILING
ReactNativeRenderer-dev.js -0.4% -0.2% 750.38 KB 747.33 KB 158.88 KB 158.53 KB RN_OSS_DEV
ReactNativeRenderer-prod.js -0.3% 🔺+0.2% 276.9 KB 276.13 KB 47.53 KB 47.6 KB RN_OSS_PROD
ReactNativeRenderer-profiling.js -0.3% +0.2% 285.83 KB 285.06 KB 49.25 KB 49.33 KB RN_OSS_PROFILING
ReactFabric-dev.js -0.4% -0.2% 755.82 KB 752.77 KB 159.72 KB 159.37 KB RN_OSS_DEV
ReactFabric-prod.js -0.3% 🔺+0.2% 268.6 KB 267.83 KB 46.13 KB 46.22 KB RN_OSS_PROD
ReactFabric-profiling.js -0.3% +0.2% 278.71 KB 277.94 KB 47.98 KB 48.07 KB RN_OSS_PROFILING

ReactDOM: size: -0.5%, gzip: -0.1%

Size changes (stable)

Generated by 🚫 dangerJS against 7768843

@sebmarkbage
Copy link
Collaborator

I don't think this should be on .updateQueue but on .memoizedState. The .updateQueue is treated as an effect queue for everything else at this point.

@acdlite
Copy link
Collaborator Author

acdlite commented Dec 10, 2019

That makes sense but I didn't want to deal with the ramifications of other stuff that reads from it. Like DevTools. At least right now.

@acdlite
Copy link
Collaborator Author

acdlite commented Dec 10, 2019

Basically I'm trying to keep the scope of this "bugfix" somewhat narrow. Can do a fuller refactor later.

Copy link
Contributor

@nicksp nicksp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious about the need for additional not-null check 🤔

' '.repeat(depth + 1) + '~',
'[' + update.expirationTime + ']',
);
} while (update !== null && update !== first);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can update be changed while inside the loop? Do we need to additionally check for not null being inside if (update !== null)?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. It's missing a update = update.next line at the end of the loop. Honestly I don't think anyone actually uses this method anymore, so I'll probably just remove it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I believe removal would be safe here and in the block below.

' '.repeat(depth + 1) + '~',
'[' + pendingUpdate.expirationTime + ']',
);
} while (pendingUpdate !== null && pendingUpdate !== firstPending);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question whether pendingUpdate needs to be checked for ! == null when already inside if check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants