Codemod it.experimental to gate pragma #18582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
acdlite
force-pushed
the
remove-it-experimental
branch
from
284730b
to
19a1c2d
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 284730b:
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3183d7d:
|
|
It's annoying how many whitespace changes there are, because the line length went down. But this illustrates the advantage of the pragma form: adding or removing a gate doesn't affect the whitespace, because the pragma goes on a separate line. |
acdlite
force-pushed
the
remove-it-experimental
branch
3 times, most recently
from
9e69f02
to
8ecf4a2
Compare
acdlite
force-pushed
the
remove-it-experimental
branch
from
8ecf4a2
to
2363413
Compare
bvaughn
approved these changes
Apr 13, 2020
Find-and-replace followed by Prettier
Removes the API from our test setup script
acdlite
force-pushed
the
remove-it-experimental
branch
from
2363413
to
3183d7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Codemods all uses of
it.experimentalto the gate pragma added in #18581.Quick review link