Migrate conditional tests to gate pragma #18585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
React Core Team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8cbba9a:
|
acdlite
force-pushed
the
migrate-conditional-tests
branch
from
d72ab22
to
4358fe2
Compare
bvaughn
approved these changes
Apr 13, 2020
| }); | ||
|
|
||
| it('traces interaction across client-rendered hydration', async done => { | ||
| // @gate experimental | ||
| it('traces interaction across client-rendered hydration', async () => { |
There was a problem hiding this comment.
nit: I don't think this test needs to be async.
| @@ -599,7 +600,8 @@ describe('ReactDOMTracing', () => { | |||
| }); | |||
|
|
|||
| describe('hydration', () => { | |||
| it('traces interaction across hydration', async done => { | |||
| // @gate experimental | |||
| it('traces interaction across hydration', async () => { | |||
There was a problem hiding this comment.
nit: I don't think this test needs to be async.
Using a heuristic where I check a flag that is known to only be enabled in www. I left a TODO to instead set the release channel explicitly in each test config.
I searched through the codebase for this pattern:
```js
describe('test suite', () => {
if (!__EXPERIMENTAL__) { // or some other condition
test("empty test so Jest doesn't complain", () => {});
return;
}
// Unless we're in experimental mode, none of the tests in this block
// will run.
})
```
and converted them to the `@gate` pragma instead.
The reason this pattern isn't preferred is because you end up disabling
more tests than you need to.
acdlite
force-pushed
the
migrate-conditional-tests
branch
5 times, most recently
from
2550b29
to
8cbba9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #18582
I split this up from the previous PR because the changes in here weren't completely automated. I had to manually edit stuff.
I searched through the codebase for this pattern:
and converted them to the
@gatepragma instead.The reason this pattern isn't preferred is because you end up disabling more tests than you need to.
Quick review link