Modern Event System: register onMouseEnter for portals #18720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
React Core Team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a19253b:
|
trueadm
force-pushed
the
fix-enter-leave
branch
from
d68162a
to
99b21b3
Compare
sebmarkbage
approved these changes
Apr 23, 2020
revise title revise title
trueadm
force-pushed
the
fix-enter-leave
branch
from
99b21b3
to
a19253b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found an issue internally with the modern event system and
onMouseEnter/onMouseLeave. Specifically, this issue occurs when we have a portal that is outside of the React root. Given we don't listen to events on the document, we need to know when an innermouseEnter/mouseLeavetraverses up through a portal to a parent that has this plugin in-use. If the portal doesn't have these event listeners attached too, then this never happens.I've added a repro test that demonstrates this.