Modern Event System: fix EnterLeave plugin logic #18830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trueadm
commented
May 5, 2020
| // We use ensureListeningTo because the container might | ||
| // be a COMMENT_NODE and this function handles events | ||
| // on comments for us. | ||
| ensureListeningTo(container, 'onMouseEnter'); |
There was a problem hiding this comment.
This is similar to what we did with the fix in #18720.
facebook-github-bot
added
the
React Core Team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2be41ca:
|
Details of bundled changes.Comparing: 7992ca1...2be41ca react-dom
ReactDOM: size: 0.0%, gzip: -0.0% Size changes (experimental) |
Details of bundled changes.Comparing: 7992ca1...2be41ca react-dom
Size changes (stable) |
trueadm
force-pushed
the
fix-enter-leave-2
branch
2 times, most recently
from
584652f
to
751f4f5
Compare
Add regression tests Fix root code Fix logic in DOMComponent Fix unused var
trueadm
commented
May 5, 2020
| // If we are not processing the first ancestor, then we | ||
| // should not process the same nativeEvent again, as we | ||
| // will have already processed it in the first ancestor. | ||
| const nativeTargetInst = getClosestInstanceFromNode(nativeEventTarget); |
There was a problem hiding this comment.
This is basically the same as what we do on:
trueadm
commented
May 5, 2020
gaearon
approved these changes
May 5, 2020
Addressed feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we found an internal issue with the modern event system and the EnterLeave plugin. Specifically, we didn't track
mouseouton the container, only in the portal. That's because the portal had a child containedonMouseEnter. This bug is actually very similar to that of the recent fix to #18720.Making this change, so that we now register this plugin on each root container fixed that issue, but also brought about another issue. This was great though, as we had already solved this in the legacy EnterLeave plugin (I commented on it below). Taking that logic and bringing it to the modern event system fixed the failing issues and aligned the modern event system with the legacy one.