DevTools: Add root and renderer version to inspected props panel #18963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
React Core Team
bvaughn
commented
May 20, 2020
|
|
||
| if (hocDisplayNames !== null) { | ||
| totalBadgeCount += hocDisplayNames.length; | ||
| if (hocDisplayNames === null) { |
There was a problem hiding this comment.
This fixes a regression from #18802 I think.
bvaughn
commented
May 20, 2020
| rendererPackageName !== null && rendererVersion !== null | ||
| ? `${rendererPackageName}@${rendererVersion}` | ||
| : null; | ||
| const showRenderedBy = |
There was a problem hiding this comment.
We'll always show this section now, except for v15.
bvaughn
commented
May 20, 2020
| if (__DEV__) { | ||
| switch (tag) { | ||
| case BlockingRoot: | ||
| this._debugRootType = 'createBlockingRoot()'; |
There was a problem hiding this comment.
This minimizes the coupling between React and DevTools.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5dbafca:
|
Details of bundled changes.Comparing: 099f737...5dbafca react-dom
react-art
react-test-renderer
react-reconciler
react-native-renderer
ReactDOM: size: 0.0%, gzip: -0.0% Size changes (experimental) |
Details of bundled changes.Comparing: 099f737...5dbafca react-native-renderer
react-dom
react-art
react-test-renderer
react-reconciler
ReactDOM: size: 0.0%, gzip: -0.0% Size changes (stable) |
lunaruan
reviewed
May 21, 2020
Comment on lines
432
to
433
| {owners !== null && | ||
| owners.length > 0 && |
There was a problem hiding this comment.
Are you intentionally checing this condition twice (also in showRenderedBy)?
There was a problem hiding this comment.
Yes in that the !== null check is for Flow. I guess I could technically get rid of the second owners.length check if I moved owners !== null && owners.length > 0 above into a second variable– or if I added an explicit inline casting- but it seemed kind of not worth doing since it's not really hot path code.
There was a problem hiding this comment.
I'll just add the Flow casting to get rid of the second check though 😄 I don't mind.
lunaruan
approved these changes
May 21, 2020
bvaughn
force-pushed
the
devtools-meta-info
branch
from
fbacbf5
to
5dbafca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the root API and renderer version to the bottom of the "rendered by" list. (If this info is missing, we degrade gracefully.)
Screenshots