[DevTools] Named hooks #19097
Closed
[DevTools] Named hooks #19097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit cc31c03:
|
Details of bundled changes.Comparing: 4c7036e...cc31c03 react-dom
react-debug-tools
react-native-renderer
react-art
react-test-renderer
react-reconciler
react-named-hooks
Size changes (experimental) |
Details of bundled changes.Comparing: 4c7036e...cc31c03 react-dom
react-debug-tools
react-art
react-test-renderer
react-native-renderer
react-reconciler
react-named-hooks
ReactDOM: size: 0.0%, gzip: -0.0% Size changes (stable) |
bl00mber
force-pushed
the
devtools/named-hooks
branch
5 times, most recently
from
b97cdfd
to
6c16fa8
Compare
bl00mber
force-pushed
the
devtools/named-hooks
branch
from
6c16fa8
to
cc31c03
Compare
|
Sorry we haven't gotten around to reviewing yet. This will be important to get back to but we haven't prioritized it yet. |
|
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
|
Bump |
|
Thanks for the PR! I'm not ready to dig into this yet, although I think this is probably more of the direction we'll end up heading with this feature, (once we have the bandwidth to land the change and test it and roll it out): It's more complicated but it "just works" without adding bytes to the bundle or requiring changes be made to existing apps. |
|
Thank you for this PR! We ended up going with another solution for this: #21641 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#16474
This is the implementation of main proposed solution based on babel DEV-only AST transform, supporting built-in hooks.
If name is the default hook name (i.e. state for setState, reducer for useReducer), the hook is not injected by transform plugin and ignored by devtools.
Three methods of hook name extraction are used: first array item, identifier name, first argument name.
Supports:
Before
After