Use jest-environment-jsdom-sixteen #19288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3504e56:
|
SimenB
reviewed
Jul 8, 2020
SimenB
reviewed
Jul 8, 2020
|
We still need to wait for the jsdom release to get this in, right? |
rickhanlonii
force-pushed
the
rh-jsdom-16
branch
from
c2c57c4
to
3504e56
Compare
|
@gaearon this should be good to go now |
|
Is there a test that will fail if we don't have the JSDOM fix as expected just to double check or has that not landed yet? |
|
It's #19186. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Do not merge until JSDOM publishes a new version
This PR replaces the jsdom resolution override with using
jest-environment-jsdom-sixteenas the test runner until we update to Jest 26Test Plan