Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset new fork to old fork #20254

Merged
merged 3 commits into from
Nov 13, 2020
Merged

Reset new fork to old fork #20254

merged 3 commits into from
Nov 13, 2020

Commits on Nov 13, 2020

  1. Fix typo 

    This typo was fixed in the new fork but not the old.
    @acdlite
    acdlite committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    8cd860b View commit details
    Browse the repository at this point in the history

  2. Reset new fork to old fork 

    Something in the new fork is causing a topline metrics regression. We're
not sure what it is, so we're going to split it into steps and bisect.

As a first step, this resets the new fork back to the contents of the
old fork. We will land this to confirm that the fork infra itself is
not causing a regression.
    @acdlite
    acdlite committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    eb2758b View commit details
    Browse the repository at this point in the history

  3. Fix tests: Add dfsEffectsRefactor flag 

    Some of the tests that gated on the effects refactor used the `new`
flag. In order to bisect, we'll need to decompose the new fork changes
into multiple steps.

So I added a hardcoded test flag called `dfsEffectsRefactor` and set it
to false. Will turn back on when we switch back to traversing the
finished tree using DFS and `subtreeTag`.
    @acdlite
    acdlite committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    1efb4a8 View commit details
    Browse the repository at this point in the history