Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix codesandbox build command #20731

Merged
merged 1 commit into from
Feb 4, 2021

Conversation

rickhanlonii
Copy link
Member

Overview

Hopefully this fixes the generated sandboxes on PRs.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 3, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit aa59e4f:

Sandbox Source
React Configuration

@sizebot
Copy link

sizebot commented Feb 4, 2021

Size changes

Comparing: 00e38c8...aa59e4f

Stable channel

No significant bundle size changes to report.

Experimental channel

No significant bundle size changes to report.

Generated by 🚫 dangerJS against aa59e4f

Copy link
Collaborator

@acdlite acdlite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. In the future it'd be nice to download the CI artifacts instead of building from source.

@rickhanlonii
Copy link
Member Author

Unfortunately this isn't fixed yet, still working with the team to debug

@rickhanlonii
Copy link
Member Author

Fixed!

@rickhanlonii rickhanlonii merged commit b12d007 into facebook:master Feb 4, 2021
@rickhanlonii rickhanlonii added the React Core Team Opened by a member of the React Core Team label Feb 11, 2021
koto pushed a commit to koto/react that referenced this pull request Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants