Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fizz/Flight] Log all errors to console.error by default on the server #21130

Merged
merged 1 commit into from
Mar 30, 2021

Conversation

sebmarkbage
Copy link
Collaborator

Builds on #21129 and #21056.

It can be tricky to discover server errors, especially errors in React itself or where we gracefully fallback or hand off to the client.

In ReactDOM client, we log all errors to the console even if they're handled by an error boundary. You have to attach a global onerror listener and preventDefault on that to silence those errors.

On the server you can pass an onError callback. I went with an approach where if you don't pass an onError callback we log to the console by default. But if you do, then we don't. So it's up to you to ensure that you log them somehow if you implement this callback.

In the future we might attach component stacks to both the onError callback and these logs, but we don't have components stacks neither in Flight nor Fizz yet.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Mar 29, 2021
@sizebot
Copy link

sizebot commented Mar 29, 2021

Comparing: d1294c9...d7e3b86

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 122.27 kB 122.27 kB = 39.24 kB 39.24 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 128.78 kB 128.78 kB = 41.32 kB 41.32 kB
facebook-www/ReactDOM-prod.classic.js = 404.48 kB 404.48 kB = 75.20 kB 75.20 kB
facebook-www/ReactDOM-prod.modern.js = 392.73 kB 392.73 kB = 73.32 kB 73.31 kB
facebook-www/ReactDOMForked-prod.classic.js = 404.48 kB 404.48 kB = 75.20 kB 75.20 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-server/cjs/react-server.production.min.js +0.35% 9.53 kB 9.57 kB +0.42% 3.32 kB 3.34 kB
oss-stable/react-server/cjs/react-server.production.min.js +0.35% 9.53 kB 9.57 kB +0.42% 3.32 kB 3.34 kB
oss-experimental/react-server/cjs/react-server.development.js +0.32% 36.55 kB 36.67 kB +0.49% 9.56 kB 9.60 kB
oss-stable/react-server/cjs/react-server.development.js +0.32% 36.55 kB 36.67 kB +0.49% 9.56 kB 9.60 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-writer.browser.production.min.server.js +0.26% 6.62 kB 6.64 kB +0.25% 2.79 kB 2.80 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-writer.browser.production.min.server.js +0.26% 6.62 kB 6.64 kB +0.25% 2.79 kB 2.80 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-writer.node.production.min.server.js +0.25% 6.67 kB 6.68 kB +0.25% 2.78 kB 2.78 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-writer.node.production.min.server.js +0.25% 6.67 kB 6.68 kB +0.25% 2.78 kB 2.78 kB
oss-experimental/react-server/cjs/react-server-flight.production.min.js +0.25% 6.80 kB 6.82 kB +0.18% 2.85 kB 2.85 kB
oss-stable/react-server/cjs/react-server-flight.production.min.js +0.25% 6.80 kB 6.82 kB +0.18% 2.85 kB 2.85 kB
oss-experimental/react-server-dom-webpack/umd/react-server-dom-webpack-writer.browser.production.min.server.js +0.25% 6.83 kB 6.85 kB +0.42% 2.88 kB 2.89 kB
oss-stable/react-server-dom-webpack/umd/react-server-dom-webpack-writer.browser.production.min.server.js +0.25% 6.83 kB 6.85 kB +0.42% 2.88 kB 2.89 kB
oss-experimental/react-server/cjs/react-server-flight.development.js +0.25% 26.99 kB 27.06 kB +0.33% 7.22 kB 7.24 kB
oss-stable/react-server/cjs/react-server-flight.development.js +0.25% 26.99 kB 27.06 kB +0.33% 7.22 kB 7.24 kB
facebook-relay/flight/ReactFlightNativeRelayServer-dev.js +0.25% 27.16 kB 27.23 kB +0.33% 7.20 kB 7.22 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-writer.browser.development.server.js +0.25% 27.22 kB 27.29 kB +0.33% 7.38 kB 7.41 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-writer.browser.development.server.js +0.25% 27.22 kB 27.29 kB +0.33% 7.38 kB 7.41 kB
oss-experimental/react-server-dom-webpack/umd/react-server-dom-webpack-writer.browser.development.server.js +0.25% 28.95 kB 29.02 kB +0.33% 7.53 kB 7.56 kB
oss-stable/react-server-dom-webpack/umd/react-server-dom-webpack-writer.browser.development.server.js +0.25% 28.95 kB 29.02 kB +0.33% 7.53 kB 7.56 kB
oss-experimental/react-dom/cjs/react-dom-unstable-fizz.browser.production.min.js +0.24% 13.89 kB 13.92 kB +0.27% 4.84 kB 4.85 kB
facebook-www/ReactFlightDOMRelayServer-dev.classic.js +0.24% 27.42 kB 27.49 kB +0.38% 7.13 kB 7.15 kB
facebook-www/ReactFlightDOMRelayServer-dev.modern.js +0.24% 27.42 kB 27.49 kB +0.38% 7.13 kB 7.15 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-writer.node.development.server.js +0.24% 27.55 kB 27.62 kB +0.38% 7.40 kB 7.43 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-writer.node.development.server.js +0.24% 27.55 kB 27.62 kB +0.38% 7.40 kB 7.43 kB
oss-experimental/react-dom/cjs/react-dom-unstable-fizz.node.production.min.js +0.24% 14.21 kB 14.25 kB +0.35% 4.87 kB 4.89 kB
oss-experimental/react-dom/umd/react-dom-unstable-fizz.browser.production.min.js +0.23% 14.08 kB 14.11 kB +0.30% 4.93 kB 4.95 kB
oss-experimental/react-dom/cjs/react-dom-unstable-fizz.node.development.js +0.20% 58.93 kB 59.05 kB +0.35% 14.50 kB 14.55 kB
oss-experimental/react-dom/cjs/react-dom-unstable-fizz.browser.development.js +0.20% 58.98 kB 59.10 kB +0.33% 14.58 kB 14.63 kB
oss-experimental/react-dom/umd/react-dom-unstable-fizz.browser.development.js +0.20% 62.00 kB 62.12 kB +0.32% 14.76 kB 14.81 kB

Generated by 🚫 dangerJS against d7e3b86

Copy link
Collaborator

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

export {close} from 'ReactFlightDOMRelayServerIntegration';
export {close};

export function closeWithError(destination: Destination, error: mixed): void {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are your plans for the error param passed to closeWithError?

Copy link
Collaborator Author

@sebmarkbage sebmarkbage Mar 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is used by other host configs. Notably Node.js streams accepts an error passed when forcing a stream to close:

https://github.com/facebook/react/blob/master/packages/react-server/src/ReactServerStreamConfigNode.js#L77

This just added it to the Relay specific bindings.

@sebmarkbage sebmarkbage merged commit 0853aab into facebook:master Mar 30, 2021
facebook-github-bot pushed a commit to facebook/react-native that referenced this pull request Apr 6, 2021
Summary:
This sync includes the following changes:
- **[c9aab1c9d](facebook/react@c9aab1c9d )**: react-refresh@0.10.0 //<Dan Abramov>//
- **[516b76b9a](facebook/react@516b76b9a )**: [Fast Refresh] Support callthrough HOCs ([#21104](facebook/react#21104)) //<Dan Abramov>//
- **[0853aab74](facebook/react@0853aab74 )**: Log all errors to console.error by default ([#21130](facebook/react#21130)) //<Sebastian Markbåge>//
- **[d1294c9d4](facebook/react@d1294c9d4 )**: Add global onError handler ([#21129](facebook/react#21129)) //<Sebastian Markbåge>//
- **[64983aab5](facebook/react@64983aab5 )**: Remove redundant setUpdatePriority call ([#21127](facebook/react#21127)) //<Andrew Clark>//
- **[634cc52e6](facebook/react@634cc52e6 )**: Delete dead variable: currentEventWipLanes ([#21123](facebook/react#21123)) //<Andrew Clark>//
- **[1102224bb](facebook/react@1102224bb )**: Fix: flushSync changes priority inside effect ([#21122](facebook/react#21122)) //<Andrew Clark>//
- **[dbe98a5aa](facebook/react@dbe98a5aa )**: Move sync task queue to its own module ([#21109](facebook/react#21109)) //<Andrew Clark>//
- **[3ba5c8737](facebook/react@3ba5c8737 )**: Remove Scheduler indirection ([#21107](facebook/react#21107)) //<Andrew Clark>//
- **[46b68eaf6](facebook/react@46b68eaf6 )**: Delete LanePriority type ([#21090](facebook/react#21090)) //<Andrew Clark>//
- **[dcd13045e](facebook/react@dcd13045e )**: Use Lane to track root callback priority ([#21089](facebook/react#21089)) //<Andrew Clark>//
- **[5f21a9fca](facebook/react@5f21a9fca )**: Clean up host pointers in level 2 of clean-up flag ([#21112](facebook/react#21112)) //<Andrew Clark>//
- **[32d6f39ed](facebook/react@32d6f39ed )**: [Fizz] Support special HTML/SVG/MathML tags to suspend ([#21113](facebook/react#21113)) //<Sebastian Markbåge>//
- **[a77dd13ed](facebook/react@a77dd13ed )**: Delete enableDiscreteEventFlushingChange ([#21110](facebook/react#21110)) //<Andrew Clark>//
- **[048ee4c0c](facebook/react@048ee4c0c )**: Use `act` in fuzz tester to flush expired work ([#21108](facebook/react#21108)) //<Andrew Clark>//
- **[556644e23](facebook/react@556644e23 )**: Fix plurals ([#21106](facebook/react#21106)) //<Sebastian Markbåge>//
- **[8b741437b](facebook/react@8b741437b )**: Rename SuspendedWork to Task ([#21105](facebook/react#21105)) //<Sebastian Markbåge>//
- **[38a1aedb4](facebook/react@38a1aedb4 )**: [Fizz] Add FormatContext and Refactor Work ([#21103](facebook/react#21103)) //<Sebastian Markbåge>//
- **[1b7e471b9](facebook/react@1b7e471b9 )**: React Native New Architecture: Support passing nativeViewTag to getInspectorDataForViewAtPoint callback, for React DevTools compat ([#21080](facebook/react#21080)) //<Joshua Gross>//
- **[4a99c5c3a](facebook/react@4a99c5c3a )**: Use highest priority lane to detect interruptions ([#21088](facebook/react#21088)) //<Andrew Clark>//
- **[77be52729](facebook/react@77be52729 )**: Remove LanePriority from computeExpirationTime ([#21087](facebook/react#21087)) //<Andrew Clark>//
- **[3221e8fba](facebook/react@3221e8fba )**: Remove LanePriority from getBumpedLaneForHydration ([#21086](facebook/react#21086)) //<Andrew Clark>//
- **[05ec0d764](facebook/react@05ec0d764 )**: Entangled expired lanes with SyncLane ([#21083](facebook/react#21083)) //<Andrew Clark>//
- **[03ede83d2](facebook/react@03ede83d2 )**: Use EventPriority to track update priority ([#21082](facebook/react#21082)) //<Andrew Clark>//
- **[a63f0953b](facebook/react@a63f0953b )**: Delete SyncBatchedLane ([#21061](facebook/react#21061)) //<Ricky>//
- **[fa868d6be](facebook/react@fa868d6be )**: Make opaque EventPriority type a Lane internally ([#21065](facebook/react#21065)) //<Andrew Clark>//
- **[eb58c3909](facebook/react@eb58c3909 )**: react-hooks/exhaustive-deps: Handle optional chained methods as dependency ([#20204](facebook/react#20204)) ([#20247](facebook/react#20247)) //<Ari Perkkiö>//
- **[7b84dbd16](facebook/react@7b84dbd16 )**: Fail build on deep requires in npm packages ([#21063](facebook/react#21063)) //<Dan Abramov>//
- **[2c9d8efc8](facebook/react@2c9d8efc8 )**: Add react-reconciler/constants entry point ([#21062](facebook/react#21062)) //<Dan Abramov>//
- **[d0eaf7829](facebook/react@d0eaf7829 )**: Move priorities to separate import to break cycle ([#21060](facebook/react#21060)) //<Andrew Clark>//
- **[435cff986](facebook/react@435cff986 )**: [Fizz] Expose callbacks in options for when various stages of the content is done ([#21056](facebook/react#21056)) //<Sebastian Markbåge>//
- **[25bfa287f](facebook/react@25bfa287f )**: [Experiment] Add feature flag for more aggressive memory clean-up of deleted fiber trees ([#21039](facebook/react#21039)) //<Benoit Girard>//
- **[8fe7810e7](facebook/react@8fe7810e7 )**: Remove already completed comment ([#21054](facebook/react#21054)) //<Sebastian Markbåge>//
- **[6c3202b1e](facebook/react@6c3202b1e )**: [Fizz] Use identifierPrefix to avoid conflicts within the same response ([#21037](facebook/react#21037)) //<Sebastian Markbåge>//
- **[dcdf8de7e](facebook/react@dcdf8de7e )**: Remove discrete lanes and priorities ([#21040](facebook/react#21040)) //<Andrew Clark>//
- **[ca99ae97b](facebook/react@ca99ae97b )**: Replace some flushExpired callsites ([#20975](facebook/react#20975)) //<Ricky>//
- **[1fafac002](facebook/react@1fafac002 )**: Use SyncLane for discrete event hydration ([#21038](facebook/react#21038)) //<Andrew Clark>//

Changelog:
[General][Changed] - React Native sync for revisions 6d3ecb7...c9aab1c

jest_e2e[run_all_tests]

Reviewed By: JoshuaGross

Differential Revision: D27436763

fbshipit-source-id: da79a41e26bffdcdacd293178062edf098e9b58a
acdlite pushed a commit to acdlite/react that referenced this pull request Apr 11, 2021
acdlite pushed a commit to acdlite/react that referenced this pull request Apr 13, 2021
acdlite pushed a commit to acdlite/react that referenced this pull request Apr 16, 2021
acdlite pushed a commit to acdlite/react that referenced this pull request Apr 16, 2021
acdlite pushed a commit to acdlite/react that referenced this pull request Apr 19, 2021
koto pushed a commit to koto/react that referenced this pull request Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants