Fail build on deep requires in npm packages (#21063)

facebook · Mar 24, 2021 · 7b84dbd · 7b84dbd
1 parent 2c9d8ef
commit 7b84dbd
Showing 1 changed file with 11 additions and 0 deletions.
diff --git a/scripts/rollup/build.js b/scripts/rollup/build.js
@@ -582,6 +582,17 @@ async function createBundle(bundle, bundleType) {
       const containsThisModule = pkg => id === pkg || id.startsWith(pkg + '/');
       const isProvidedByDependency = externals.some(containsThisModule);
       if (!shouldBundleDependencies && isProvidedByDependency) {
+        if (id.indexOf('/src/') !== -1) {
+          throw Error(
+            'You are trying to import ' +
+              id +
+              ' but ' +
+              externals.find(containsThisModule) +
+              ' is one of npm dependencies, ' +
+              'so it will not contain that source file. You probably want ' +
+              'to create a new bundle entry point for it instead.'
+          );
+        }
         return true;
       }
       return !!peerGlobals[id];