Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a string interpolation typo in ReactHooks test #22174

Merged
merged 1 commit into from Aug 26, 2021

Conversation

matthargett
Copy link
Contributor

Summary

While doing some React porting work, I had to debug a test failure in ReactHooks-test.internal.js, and got confused by the name. There's a typo in two places that caused the string interpolation in ~20 test names to be incorrect. This caused some relevant information to be missing when the test is failing. Fix the typo to align it with the same correct pattern elsewhere in the file. (Searched for other instances of the typo across other test files and didn't find any others.)

Test Plan

  • yarn test (now shows correct names)
  • yarn prettier
  • yarn linc

…ng confusion about which variant is failing.
@sizebot
Copy link

sizebot commented Aug 25, 2021

Comparing: b996468...0dbb2cb

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 127.58 kB 127.58 kB = 40.72 kB 40.72 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 130.40 kB 130.40 kB = 41.65 kB 41.65 kB
facebook-www/ReactDOM-prod.classic.js = 405.16 kB 405.16 kB = 75.04 kB 75.04 kB
facebook-www/ReactDOM-prod.modern.js = 393.72 kB 393.72 kB = 73.33 kB 73.32 kB
facebook-www/ReactDOMForked-prod.classic.js = 405.16 kB 405.16 kB = 75.04 kB 75.04 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 0dbb2cb

@matthargett
Copy link
Contributor Author

CI failure is unrelated: An unexpected error occurred: "https://registry.yarnpkg.com/jest-fetch-mock/-/jest-fetch-mock-3.0.3.tgz: Request failed \"501 Not Implemented\"".

@eps1lon eps1lon requested a review from bvaughn August 26, 2021 07:12
@bvaughn
Copy link
Contributor

bvaughn commented Aug 26, 2021

There's a typo in two places that caused the string interpolation in ~20 test names to be incorrect

What's the typo? Sorry, but it's not clear to me. Looks like an extra line break, but that shouldn't cause problems since the string is within "``". Was it some special whitespace character? (GitHub review tool doesn't show it.)

@eps1lon
Copy link
Collaborator

eps1lon commented Aug 26, 2021

There's a typo in two places that caused the string interpolation in ~20 test names to be incorrect

What's the typo? Sorry, but it's not clear to me. Looks like an extra line break, but that shouldn't cause problems since the string is within "``". Was it some special whitespace character? (GitHub review tool doesn't show it.)

@bvaughn

-`${(a, b)}`
+`${a}, ${b}`

One would evaluate to 'valueOfB' the new one to 'valueOfA, valueOfB'.

The linebreak came from prettier originally.

@bvaughn
Copy link
Contributor

bvaughn commented Aug 26, 2021

Ha! I don't know why I couldn't see that. I kept staring at the code wondering if it was a whitespace only change. Thanks for pointing out what I was overlooknig.

@bvaughn bvaughn merged commit 8723e77 into facebook:main Aug 26, 2021
@matthargett matthargett deleted the fix-hooks-test-strings branch August 26, 2021 19:37
facebook-github-bot pushed a commit to facebook/react-native that referenced this pull request Sep 11, 2021
Summary:
This sync includes the following changes:
- **[95d762e40](facebook/react@95d762e40 )**: Remove duplicate test //<Andrew Clark>//
- **[d4d1dc085](facebook/react@d4d1dc085 )**: Reorder VARIANT feature flags ([#22266](facebook/react#22266)) //<Dan Abramov>//
- **[2f156eafb](facebook/react@2f156eafb )**: Adjust consoleManagedByDevToolsDuringStrictMode feature flag ([#22253](facebook/react#22253)) //<Dan Abramov>//
- **[cfd819332](facebook/react@cfd819332 )**: Add useSyncExternalStore to react-debug-tools ([#22240](facebook/react#22240)) //<Andrew Clark>//
- **[8e80592a3](facebook/react@8e80592a3 )**: Remove state queue from useSyncExternalStore ([#22265](facebook/react#22265)) //<Andrew Clark>//
- **[06f98c168](facebook/react@06f98c168 )**: Implement useSyncExternalStore in Fiber ([#22239](facebook/react#22239)) //<Andrew Clark>//
- **[77912d9a0](facebook/react@77912d9a0 )**: Wire up the native API for useSyncExternalStore ([#22237](facebook/react#22237)) //<Andrew Clark>//
- **[031abd24b](facebook/react@031abd24b )**: Add warning and test for useSyncExternalStore when getSnapshot isn't cached ([#22262](facebook/react#22262)) //<salazarm>//
- **[b8884de24](facebook/react@b8884de24 )**: break up import keyword to avoid being accidentally parsed as dynamic import statement in external code ([#21918](facebook/react#21918)) //<Jianhua Zheng>//
- **[6d6bba5bf](facebook/react@6d6bba5bf )**: Fix typo in ReactUpdatePriority-test.js ([#21958](facebook/react#21958)) //<Ikko Ashimine>//
- **[0c0d1ddae](facebook/react@0c0d1ddae )**: feat(eslint-plugin-react-hooks): support ESLint 8.x ([#22248](facebook/react#22248)) //<Michaël De Boey>//
- **[1314299c7](facebook/react@1314299c7 )**: Initial shim of useSyncExternalStore ([#22211](facebook/react#22211)) //<Andrew Clark>//
- **[fc40f02ad](facebook/react@fc40f02ad )**: Add consoleManagedByDevToolsDuringStrictMode feature flag in React Reconciler ([#22196](facebook/react#22196)) //<Luna Ruan>//
- **[46a0f050a](facebook/react@46a0f050a )**: Set up use-sync-external-store package ([#22202](facebook/react#22202)) //<Andrew Clark>//
- **[8723e772b](facebook/react@8723e772b )**: Fix a string interpolation typo in ReactHooks test ([#22174](facebook/react#22174)) //<Matt Hargett>//
- **[60a30cf32](facebook/react@60a30cf32 )**: Console Logging for StrictMode Double Rendering ([#22030](facebook/react#22030)) //<Luna Ruan>//
- **[76bbad3e3](facebook/react@76bbad3e3 )**: Add maxYieldMs feature flag in Scheduler ([#22165](facebook/react#22165)) //<Ricky>//
- **[b0b53ae2c](facebook/react@b0b53ae2c )**: Add feature flags for scheduler experiments ([#22105](facebook/react#22105)) //<Ricky>//

Changelog:
[General][Changed] - React Native sync for revisions bd5bf55...95d762e

jest_e2e[run_all_tests]

Reviewed By: mdvacca

Differential Revision: D30809906

fbshipit-source-id: 131cfdf91e15f67fa59a5d925467e538ee89fe10
zhengjitf pushed a commit to zhengjitf/react that referenced this pull request Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants