Ensure devtools e2e test use a compatible react-is version #22790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
force-pushed
the
test/devtools-e2e
branch
from
4ea44ee
to
2780cf1
Compare
bvaughn
approved these changes
Nov 19, 2021
| @@ -146,5 +146,8 @@ | |||
| "download-build": "node ./scripts/release/download-experimental-build.js", | |||
| "download-build-for-head": "node ./scripts/release/download-experimental-build.js --commit=$(git rev-parse HEAD)", | |||
| "download-build-in-codesandbox-ci": "cd scripts/release && yarn install && cd ../../ && yarn download-build-for-head || yarn build-combined --type=node react/index react-dom scheduler" | |||
| }, | |||
| "resolutions": { | |||
| "**/@playwright/test/**/react-is": "^16.0.0" | |||
There was a problem hiding this comment.
Could this resolution be declared in the react-devtools-inline package (since that's the only thing that uses @playwright)? Just curious.
There was a problem hiding this comment.
Good question. I always declare them in the root. I tested it quickly and it didn't have any effect when declared in a nested package.
Though it may be preferred to declare it at the root in case another package uses @playwright/test?
eps1lon
force-pushed
the
test/devtools-e2e
branch
from
2780cf1
to
3015bf4
Compare
|
Comparing: bddbfb8...3015bf4 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
zhengjitf
pushed a commit
to zhengjitf/react
that referenced
this pull request
Apr 15, 2022
…22790) * Update lockfile by running `yarn install` * Ensure devtools e2e test use a compatible react-is version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #22792
Fixes #22754 (comment)
The odd part was that the
pretty-formatused by Jest (node_modules/pretty-format) does install its ownreact-isfrom npm (node_modules/pretty-format/node_modules/react-is). But the pretty-format from playwright does not and therefore uses the top-level react-is (node_modules/react-is). However, the top-level react-is is the one checked-in i.e. the uncompiled version.I used
resolutionsto enforce thatpretty-formatusesreact-isfrom npm.Note that only one test is passing at the moment. But at least they are runnable at the moment.
Summary
How did you test this change?