Skip to content

Ensure devtools e2e test use a compatible react-is version #22790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bvaughn merged 2 commits into from
Nov 19, 2021
Merged

Ensure devtools e2e test use a compatible react-is version #22790

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
299fcf4
Update lockfile by running `yarn install`
eps1lon Nov 19, 2021
3015bf4
Ensure devtools e2e test use a compatible react-is version
eps1lon Nov 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,5 +146,8 @@
"download-build": "node ./scripts/release/download-experimental-build.js",
"download-build-for-head": "node ./scripts/release/download-experimental-build.js --commit=$(git rev-parse HEAD)",
"download-build-in-codesandbox-ci": "cd scripts/release && yarn install && cd ../../ && yarn download-build-for-head || yarn build-combined --type=node react/index react-dom scheduler"
},
"resolutions": {
"**/@playwright/test/**/react-is": "^16.0.0"
Copy link
Contributor

@bvaughn bvaughn Nov 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this resolution be declared in the react-devtools-inline package (since that's the only thing that uses @playwright)? Just curious.

Copy link
Collaborator Author

@eps1lon eps1lon Nov 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. I always declare them in the root. I tested it quickly and it didn't have any effect when declared in a nested package.

Though it may be preferred to declare it at the root in case another package uses @playwright/test?

Copy link
Contributor

@bvaughn bvaughn Nov 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that's fair.

}
}
Loading