Support marginHeight and marginWidth attributes #2658
Conversation
marginHeight and marginWidth are used on iframes to set the default body margin inside the iframe.
|
I wonder if these haven't been superseded by any other property/style? They seem quite exotic (and not present in HTML5) so I can't really find any good informaton. Anyway... it seems they're available as properties even in IE8 and probably shouldn't have |
|
I was trying to find some styles that would supercede them but couldn't. We also already have |
| @@ -104,6 +104,8 @@ var HTMLDOMPropertyConfig = { | |||
| list: MUST_USE_ATTRIBUTE, | |||
| loop: MUST_USE_PROPERTY | HAS_BOOLEAN_VALUE, | |||
| manifest: MUST_USE_ATTRIBUTE, | |||
| marginHeight: MUST_USE_ATTRIBUTE, | |||
| marginWidth: MUST_USE_ATTRIBUTE, | |||
There was a problem hiding this comment.
If updating these works as properties, let's just do that.
|
👍 |
Support marginHeight and marginWidth attributes
Support marginHeight and marginWidth attributes
|
Changes Unknown when pulling 9d7467e on ianobermiller:margin-attrs into * on facebook:master*. |
|
thanks for the update @coveralls |
marginHeight and marginWidth are used on iframes to set the default body margin inside the iframe.