Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add useFormStatus to server rendering stub #26788

Merged
merged 1 commit into from May 7, 2023
Merged

Add useFormStatus to server rendering stub #26788

merged 1 commit into from May 7, 2023

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented May 6, 2023 •
edited

This was an oversight when I set up the hook in #26719.

@acdlite acdlite requested a review from gnoff May 6, 2023 23:57
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels May 6, 2023
@acdlite acdlite force-pushed the add-useformstatus-ssr-stub branch from 034dbdb to c6a0e59 Compare May 7, 2023 00:00
@react-sizebot
Copy link

react-sizebot commented May 7, 2023 •
edited

Comparing: efb381b...4ad432a

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 164.19 kB 164.19 kB = 51.78 kB 51.78 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 171.55 kB 171.55 kB = 53.98 kB 53.98 kB
facebook-www/ReactDOM-prod.classic.js = 570.13 kB 570.13 kB = 100.62 kB 100.62 kB
facebook-www/ReactDOM-prod.modern.js = 553.87 kB 553.87 kB = 97.80 kB 97.80 kB
oss-experimental/react-dom/cjs/react-dom-server-rendering-stub.development.js +72.98% 3.60 kB 6.22 kB +89.12% 1.21 kB 2.29 kB
oss-experimental/react-dom/umd/react-dom-server-rendering-stub.development.js +68.45% 4.01 kB 6.76 kB +82.84% 1.32 kB 2.42 kB
oss-experimental/react-dom/cjs/react-dom-server-rendering-stub.production.min.js +15.95% 1.18 kB 1.37 kB +10.06% 0.69 kB 0.76 kB
oss-experimental/react-dom/umd/react-dom-server-rendering-stub.production.min.js +14.15% 1.40 kB 1.60 kB +8.68% 0.81 kB 0.88 kB
oss-stable-semver/react-dom/cjs/react-dom-server-rendering-stub.production.min.js +5.93% 1.15 kB 1.22 kB +3.48% 0.66 kB 0.68 kB
oss-stable/react-dom/cjs/react-dom-server-rendering-stub.production.min.js +5.80% 1.17 kB 1.24 kB +3.37% 0.68 kB 0.71 kB
oss-stable-semver/react-dom/umd/react-dom-server-rendering-stub.production.min.js +4.61% 1.37 kB 1.43 kB +3.33% 0.78 kB 0.81 kB
oss-stable/react-dom/umd/react-dom-server-rendering-stub.production.min.js +4.52% 1.39 kB 1.46 kB +3.24% 0.80 kB 0.83 kB
oss-stable-semver/react-dom/cjs/react-dom-server-rendering-stub.development.js +3.67% 3.57 kB 3.70 kB +3.72% 1.18 kB 1.23 kB
oss-stable/react-dom/cjs/react-dom-server-rendering-stub.development.js +3.65% 3.59 kB 3.72 kB +3.72% 1.21 kB 1.25 kB
oss-stable-semver/react-dom/umd/react-dom-server-rendering-stub.development.js +3.59% 3.98 kB 4.12 kB +3.63% 1.30 kB 1.34 kB
oss-stable/react-dom/umd/react-dom-server-rendering-stub.development.js +3.57% 4.00 kB 4.15 kB +3.63% 1.32 kB 1.37 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-dom/cjs/react-dom-server-rendering-stub.development.js +72.98% 3.60 kB 6.22 kB +89.12% 1.21 kB 2.29 kB
oss-experimental/react-dom/umd/react-dom-server-rendering-stub.development.js +68.45% 4.01 kB 6.76 kB +82.84% 1.32 kB 2.42 kB
oss-experimental/react-dom/cjs/react-dom-server-rendering-stub.production.min.js +15.95% 1.18 kB 1.37 kB +10.06% 0.69 kB 0.76 kB
oss-experimental/react-dom/umd/react-dom-server-rendering-stub.production.min.js +14.15% 1.40 kB 1.60 kB +8.68% 0.81 kB 0.88 kB
oss-stable-semver/react-dom/cjs/react-dom-server-rendering-stub.production.min.js +5.93% 1.15 kB 1.22 kB +3.48% 0.66 kB 0.68 kB
oss-stable/react-dom/cjs/react-dom-server-rendering-stub.production.min.js +5.80% 1.17 kB 1.24 kB +3.37% 0.68 kB 0.71 kB
oss-stable-semver/react-dom/umd/react-dom-server-rendering-stub.production.min.js +4.61% 1.37 kB 1.43 kB +3.33% 0.78 kB 0.81 kB
oss-stable/react-dom/umd/react-dom-server-rendering-stub.production.min.js +4.52% 1.39 kB 1.46 kB +3.24% 0.80 kB 0.83 kB
oss-stable-semver/react-dom/cjs/react-dom-server-rendering-stub.development.js +3.67% 3.57 kB 3.70 kB +3.72% 1.18 kB 1.23 kB
oss-stable/react-dom/cjs/react-dom-server-rendering-stub.development.js +3.65% 3.59 kB 3.72 kB +3.72% 1.21 kB 1.25 kB
oss-stable-semver/react-dom/umd/react-dom-server-rendering-stub.development.js +3.59% 3.98 kB 4.12 kB +3.63% 1.30 kB 1.34 kB
oss-stable/react-dom/umd/react-dom-server-rendering-stub.development.js +3.57% 4.00 kB 4.15 kB +3.63% 1.32 kB 1.37 kB

Generated by 🚫 dangerJS against 4ad432a

@acdlite
Copy link
Collaborator Author

acdlite commented May 7, 2023

Oh I see, I should add it here: https://github.com/facebook/react/blob/main/packages/react-dom/src/__tests__/react-dom-server-rendering-stub-test.js

@acdlite
Add useFormStatus to server rendering stub
4ad432a 
This was an oversight when I set up the hook in facebook#26719
@acdlite acdlite force-pushed the add-useformstatus-ssr-stub branch from c6a0e59 to 4ad432a Compare May 7, 2023 00:16
@acdlite acdlite merged commit 16d053d into facebook:main May 7, 2023
36 checks passed
acdlite added a commit to acdlite/next.js that referenced this pull request May 7, 2023
@acdlite
Upgrade React to 18.3.0-canary-16d053d59-20230506
424cf23 
Fixes a bug where `useFormStatus` crashed during SSR.

Includes the following upstream changes:

- [16d053d59](https://github.com/facebook/react/commits/16d053d59) Add useFormStatus to server rendering stub ([vercel#26788](facebook/react#26788)) (Andrew Clark)
- [efb381bbf](https://github.com/facebook/react/commits/efb381bbf) [Release Script] Print a hint where to get the token ([vercel#26783](facebook/react#26783)) (dan)
- [b00e27342](https://github.com/facebook/react/commits/b00e27342) Use native scheduler if defined in global scope ([vercel#26554](facebook/react#26554)) (Samuel Susla)
- [783e7fcfa](https://github.com/facebook/react/commits/783e7fcfa) React DevTools 4.27.6 -> 4.27.7 ([vercel#26780](facebook/react#26780)) (Ruslan Lesiutin)
- [377c5175f](https://github.com/facebook/react/commits/377c5175f) DevTools: fix backend activation ([vercel#26779](facebook/react#26779)) (Ruslan Lesiutin)
@acdlite acdlite mentioned this pull request May 7, 2023
Merged
acdlite added a commit to acdlite/next.js that referenced this pull request May 7, 2023
@acdlite
Upgrade React to 18.3.0-canary-16d053d59-20230506
123efcf 
Fixes a bug where `useFormStatus` crashed during SSR.

Includes the following upstream changes:

- [16d053d59](https://github.com/facebook/react/commits/16d053d59) Add useFormStatus to server rendering stub ([vercel#26788](facebook/react#26788)) (Andrew Clark)
- [efb381bbf](https://github.com/facebook/react/commits/efb381bbf) [Release Script] Print a hint where to get the token ([vercel#26783](facebook/react#26783)) (dan)
- [b00e27342](https://github.com/facebook/react/commits/b00e27342) Use native scheduler if defined in global scope ([vercel#26554](facebook/react#26554)) (Samuel Susla)
- [783e7fcfa](https://github.com/facebook/react/commits/783e7fcfa) React DevTools 4.27.6 -> 4.27.7 ([vercel#26780](facebook/react#26780)) (Ruslan Lesiutin)
- [377c5175f](https://github.com/facebook/react/commits/377c5175f) DevTools: fix backend activation ([vercel#26779](facebook/react#26779)) (Ruslan Lesiutin)
acdlite added a commit to acdlite/next.js that referenced this pull request May 7, 2023
@acdlite
Upgrade React to 18.3.0-canary-16d053d59-20230506
8b0485e 
Fixes a bug where `useFormStatus` crashed during SSR.

Includes the following upstream changes:

- [16d053d59](https://github.com/facebook/react/commits/16d053d59) Add useFormStatus to server rendering stub ([vercel#26788](facebook/react#26788)) (Andrew Clark)
- [efb381bbf](https://github.com/facebook/react/commits/efb381bbf) [Release Script] Print a hint where to get the token ([vercel#26783](facebook/react#26783)) (dan)
- [b00e27342](https://github.com/facebook/react/commits/b00e27342) Use native scheduler if defined in global scope ([vercel#26554](facebook/react#26554)) (Samuel Susla)
- [783e7fcfa](https://github.com/facebook/react/commits/783e7fcfa) React DevTools 4.27.6 -> 4.27.7 ([vercel#26780](facebook/react#26780)) (Ruslan Lesiutin)
- [377c5175f](https://github.com/facebook/react/commits/377c5175f) DevTools: fix backend activation ([vercel#26779](facebook/react#26779)) (Ruslan Lesiutin)
kodiakhq bot pushed a commit to vercel/next.js that referenced this pull request May 7, 2023
@acdlite
Upgrade React to 18.3.0-canary-16d053d59-20230506 (#49402)
7e02f11 
Fixes a bug where `useFormStatus` crashed during SSR.

Includes the following upstream changes:

- [16d053d59](https://github.com/facebook/react/commits/16d053d59) Add useFormStatus to server rendering stub ([#26788](facebook/react#26788)) (Andrew Clark)
- [efb381bbf](https://github.com/facebook/react/commits/efb381bbf) [Release Script] Print a hint where to get the token ([#26783](facebook/react#26783)) (dan)
- [b00e27342](https://github.com/facebook/react/commits/b00e27342) Use native scheduler if defined in global scope ([#26554](facebook/react#26554)) (Samuel Susla)
- [783e7fcfa](https://github.com/facebook/react/commits/783e7fcfa) React DevTools 4.27.6 -> 4.27.7 ([#26780](facebook/react#26780)) (Ruslan Lesiutin)
- [377c5175f](https://github.com/facebook/react/commits/377c5175f) DevTools: fix backend activation ([#26779](facebook/react#26779)) (Ruslan Lesiutin)
@RootedXpert
Copy link

Hi team.
in the process of attempting to import the same hook for use in a nextjs project. It is returning undefined

EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
@acdlite @AndyPengc12
Add useFormStatus to server rendering stub (facebook#26788)
a96fe67 
This was an oversight when I set up the hook in facebook#26719.
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
@acdlite
Add useFormStatus to server rendering stub (#26788)
4e6ccd7 
This was an oversight when I set up the hook in #26719.

DiffTrain build for commit 16d053d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnoff gnoff Awaiting requested review from gnoff

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@acdlite @react-sizebot @RootedXpert @facebook-github-bot