Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jest: remove haste config #27257

Merged
merged 1 commit into from Aug 22, 2023
Merged

Jest: remove haste config #27257

merged 1 commit into from Aug 22, 2023

Conversation

kassens
Copy link
Member

@kassens kassens commented Aug 21, 2023

Since we're not using haste at all, we can just remove the config to disable haste instead of enabling, just to inject an implementation that blocks any haste modules from being recognized.

Test Plan:
Creating a module and required it to get the expected error that the module doesn't exist.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Aug 21, 2023
@react-sizebot
Copy link

Comparing: b277259...e0a70e5

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 165.67 kB 165.67 kB = 51.99 kB 51.99 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 173.16 kB 173.16 kB = 54.21 kB 54.21 kB
facebook-www/ReactDOM-prod.classic.js = 570.50 kB 570.50 kB = 100.49 kB 100.49 kB
facebook-www/ReactDOM-prod.modern.js = 554.30 kB 554.30 kB = 97.66 kB 97.66 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against e0a70e5

Copy link

@AbdullahWins AbdullahWins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done!

@kassens kassens merged commit 3f5b8c2 into facebook:main Aug 22, 2023
36 checks passed
@kassens kassens deleted the jest-config-haste branch April 2, 2024 19:21
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
Since we're not using haste at all, we can just remove the config to
disable haste instead of enabling, just to inject an implementation that
blocks any haste modules from being recognized.

Test Plan:
Creating a module and required it to get the expected error that the
module doesn't exist.
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
Since we're not using haste at all, we can just remove the config to
disable haste instead of enabling, just to inject an implementation that
blocks any haste modules from being recognized.

Test Plan:
Creating a module and required it to get the expected error that the
module doesn't exist.

DiffTrain build for commit 3f5b8c2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants