[Fizz] Track Key Path #27243
Merged
[Fizz] Track Key Path #27243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tracks the currently executing parent path of a task, using the name of the component and the key or index. This can be used to uniquely identify and instance of a component between requests - assuming nothing has changed.
facebook-github-bot
added
CLA Signed
React Core Team
sebmarkbage
commented
Aug 18, 2023
| const props = element.props; | ||
| const ref = element.ref; | ||
| const name = getComponentNameFromType(type); |
There was a problem hiding this comment.
Since we're going to go check the type again in renderElement, we could move this code deeper and extract the name in each slot but there's so much code duplication I stayed away from that even though that's my usual M.O.
sebmarkbage
commented
Aug 18, 2023
| if (isArray(node) || getIteratorFn(node)) { | ||
| // Nested arrays behave like a "fragment node" which is keyed. | ||
| // Therefore we need to add the current index as a parent key. | ||
| task.keyPath = [task.keyPath, '', childIndex]; |
There was a problem hiding this comment.
This is subtle but the first array inside of a component is the same as having a single element with slot 0. So the array itself doesn't take up slot 0. In other words, we the outer most array doesn't get added to the path but the next one gets treated as if it was a fragment element in that slot.
|
This will allocate quite a lot of nodes but hopefully the young generation collector takes them quick. A possible alternative implementation could push/pop to an array in the recursive path and clone whenever it spawns a new task. We don't do that for contexts but it might make more sense for this one. |
acdlite
approved these changes
Aug 18, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Aug 18, 2023
Tracks the currently executing parent path of a task, using the name of the component and the key or index. This can be used to uniquely identify an instance of a component between requests - assuming nothing in the parents has changed. Even if it has changed, if things are properly keyed, it should still line up. It's not used yet but we'll need this for two separate features so should land this so we can stack on top. Can be passed to `JSON.stringify(...)` to generate a unique key. DiffTrain build for [98f3f14](98f3f14)
kodiakhq bot
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 22, 2023
### React upstream changes - facebook/react#27265 - facebook/react#27259 - facebook/react#27264 - facebook/react#27257 - facebook/react#27258 - facebook/react#27187 - facebook/react#27243 - facebook/react#27205 - facebook/react#27220 - facebook/react#27238 - facebook/react#27234 - facebook/react#27224 - facebook/react#27223 - facebook/react#27222 This will help unblock #53906
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
Tracks the currently executing parent path of a task, using the name of the component and the key or index. This can be used to uniquely identify an instance of a component between requests - assuming nothing in the parents has changed. Even if it has changed, if things are properly keyed, it should still line up. It's not used yet but we'll need this for two separate features so should land this so we can stack on top. Can be passed to `JSON.stringify(...)` to generate a unique key.
bigfootjon
pushed a commit
that referenced
this pull request
Apr 18, 2024
Tracks the currently executing parent path of a task, using the name of the component and the key or index. This can be used to uniquely identify an instance of a component between requests - assuming nothing in the parents has changed. Even if it has changed, if things are properly keyed, it should still line up. It's not used yet but we'll need this for two separate features so should land this so we can stack on top. Can be passed to `JSON.stringify(...)` to generate a unique key. DiffTrain build for commit 98f3f14.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracks the currently executing parent path of a task, using the name of the component and the key or index.
This can be used to uniquely identify an instance of a component between requests - assuming nothing in the parents has changed. Even if it has changed, if things are properly keyed, it should still line up.
It's not used yet but we'll need this for two separate features so should land this so we can stack on top.
Can be passed to
JSON.stringify(...)to generate a unique key.