Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make class prop resolution faster #28766

Merged
merged 1 commit into from
Apr 5, 2024

Commits on Apr 5, 2024

  1. Make class prop resolution faster

    `delete` causes an object (in V8, and maybe other engines) to deopt to
    a dictionary instead of a class. Instead of `assign` + `delete`,
    manually iterate over all the properties, like the JSX runtime does.
    
    To avoid copying the object twice I moved the `ref` prop removal to
    come before handling default props. If we already cloned the props to
    remove `ref`, then we can skip cloning again to handle default props.
    acdlite committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    1c6dac7 View commit details
    Browse the repository at this point in the history