[Fiber] clarify entry condition for suspensey commit recursion #29222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
gnoff
force-pushed
the
clarify-suspensey-recursion-trigger
branch
2 times, most recently
from
a409ff2
to
30d249b
Compare
|
Comparing: 3ac551e...09f87eb Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
acdlite
reviewed
May 23, 2024
| @@ -1185,7 +1185,7 @@ function commitRootWhenReady( | |||
| ) { | |||
| // TODO: Combine retry throttling with Suspensey commits. Right now they run | |||
| // one after the other. | |||
| if (finishedWork.subtreeFlags & ShouldSuspendCommit) { | |||
| if (finishedWork.subtreeFlags & (ShouldSuspendCommit | Visibility)) { | |||
There was a problem hiding this comment.
To make this even more specific, if ShouldSuspendCommit is not present, it should check if both Visibility and MaySuspendCommit are set. If there's no MaySuspendCommit flag it can bail out.
So something like:
const BothShouldSuspendCommitAndVisibility = ShouldSuspendCommit | Visibility;
if (
subtreeFlags & SoundSuspendCommit ||
((subtreeFlags & BothShouldSuspendCommitAndVisibility) === BothShouldSuspendCommitAndVisibility)
acdlite
approved these changes
May 23, 2024
Previously Suspensey recursion would only trigger if the ShouldSuspendCommit flag was true. However there is a dependence on the Visibility flag embedded in this logic because these flags share a bit. To make it clear that the semantics of Suspensey resources require considering both flags I've added it to the condition even though this extra or-ing is a noop when the bit is shared
gnoff
force-pushed
the
clarify-suspensey-recursion-trigger
branch
from
30d249b
to
09f87eb
Compare
github-actions bot
pushed a commit
that referenced
this pull request
May 23, 2024
Previously Suspensey recursion would only trigger if the ShouldSuspendCommit flag was true. However there is a dependence on the Visibility flag embedded in this logic because these flags share a bit. To make it clear that the semantics of Suspensey resources require considering both flags I've added it to the condition even though this extra or-ing is a noop when the bit is shared DiffTrain build for commit f55d172.
github-actions bot
pushed a commit
that referenced
this pull request
May 23, 2024
Previously Suspensey recursion would only trigger if the ShouldSuspendCommit flag was true. However there is a dependence on the Visibility flag embedded in this logic because these flags share a bit. To make it clear that the semantics of Suspensey resources require considering both flags I've added it to the condition even though this extra or-ing is a noop when the bit is shared DiffTrain build for [f55d172](f55d172)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously Suspensey recursion would only trigger if the ShouldSuspendCommit flag was true. However there is a dependence on the Visibility flag embedded in this logic because these flags share a bit. To make it clear that the semantics of Suspensey resources require considering both flags I've added it to the condition even though this extra or-ing is a noop when the bit is shared