[Fiber] use unique flag for ShouldSuspendCommit #29220
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously ShouldSuspendCommit was sharing the bit with Visibility. However now that we enter the suspend loop during commit anytime this flag is set it means we might be doing this traversal more often than needed given the prevalent use of Visibility with Suspense. To avoid unecessarily recursing here this change moves this flag to it's own bit. We're quite low on bits but we still have a couple more so instead of looking for a different suitable flag to share with Visibility I'm just consuming a new one. (Sorry future React person who eventually has to solve this)
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: 3ac551e...57b8622 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
|
turns out the shared bit is better: #29222 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously ShouldSuspendCommit was sharing the bit with Visibility. However now that we enter the suspend loop during commit anytime this flag is set it means we might be doing this traversal more often than needed given the prevalent use of Visibility with Suspense.
To avoid unecessarily recursing here this change moves this flag to it's own bit. We're quite low on bits but we still have a couple more so instead of looking for a different suitable flag to share with Visibility I'm just consuming a new one. (Sorry future React person who eventually has to solve this)