Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use console.error to show stack trace in console #3277

Closed
wants to merge 1 commit into from
Closed

Use console.error to show stack trace in console #3277

wants to merge 1 commit into from

Conversation

sophiebits
Copy link
Contributor

No description provided.

@zpao
Copy link
Member

zpao commented Feb 28, 2015

Do we want to squeeze this in for 0.13?

@sebmarkbage
Copy link
Collaborator

Let's wait on this one. The console.warn !== originalWarn isn't safe outside our environment. We should just switch to always use console.error everywhere and tests will have to update.

@sophiebits sophiebits closed this Mar 17, 2015
sophiebits added a commit to sophiebits/react that referenced this pull request Mar 17, 2015
@sophiebits
Use console.error to show stack trace in console
e791fcc 
Better version of facebook#3277.

Test Plan: jest, grunt test
@sophiebits sophiebits mentioned this pull request Mar 17, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sophiebits @zpao @sebmarkbage