Make setState in render a warning, not an invariant #4091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We keep track of the fact that something is rendering for a bunch of warnings. (ReactCurrentOwner.current !== null) Once we get rid of owner for string refs, I'll convert those to something like "isRendering" instead. The interesting part is that feature `__DEV__` only. It is only used for warnings. Except for this case. This means that we can get rid of the special case for the isRendering stack on in prod.
sebmarkbage
force-pushed
the
updatequeuewarning
branch
from
688e9c5
to
02aafb5
Compare
| render: function() { | ||
| renderedState = this.state.value; | ||
| if (this.state.value === 0) { | ||
| this.setState({ value: 1 }); |
There was a problem hiding this comment.
nit: {value: 1} like you had in getInitialState
|
👍 |
sebmarkbage
added a commit
that referenced
this pull request
Jun 12, 2015
Make setState in render a warning, not an invariant
This was referenced Mar 18, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We keep track of the fact that something is rendering for a bunch of
warnings. (ReactCurrentOwner.current !== null)
Once we get rid of owner for string refs, I'll convert those to something
like "isRendering" instead. The interesting part is that feature is
__DEV__only. It is only used for warnings. Except for this one case.This means that we can get rid of the special case for the isRendering
stack on in prod.