Build Browser Packages #4761
Closed
Build Browser Packages #4761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zpao
force-pushed
the
build-react-dom-browser
branch
from
8021845
to
a5005a8
Compare
| @@ -19,7 +19,7 @@ module.exports = function() { | |||
| 'packages/react-addons/package.json (version)': addonsData.version, | |||
| // Get the "version" without the range bit | |||
| 'packages/react-addons/package.json (react dependency)': addonsData.peerDependencies.react.slice(1), | |||
| 'src/React.js': reactVersionExp.exec(grunt.file.read('./src/React.js'))[1], | |||
| 'src/ReactVersion.js': reactVersionExp.exec(grunt.file.read('./src/ReactVersion.js'))[1], | |||
There was a problem hiding this comment.
Now that it's its own file, you could just require it…
|
Were we going to have the version on the other files? |
zpao
force-pushed
the
build-react-dom-browser
branch
from
a5005a8
to
2e46657
Compare
|
Added the version in the right places. Now what should we do about addons? I didn't really want to add 4 more builds as a result of this, but it looks like that's what's going to have to happen. |
This was referenced Sep 5, 2015
|
Going with #4814 instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP to build a new browser bundle.
cc @spicyj
Fixes #4754