Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "cite" attribute to whitelist for <blockquote> elements #6094

Merged
merged 1 commit into from Feb 24, 2016

Conversation

Projects
None yet
4 participants
@AprilArcus
Copy link
Contributor

commented Feb 23, 2016

Questions:

  • Would you like tests?
  • Would it be better if this whitelist were scoped to the node type of the parent element? cite is meaningless for any element but <blockquote>, but will be rendered into the DOM for any component per the general whitelist.

@AprilArcus AprilArcus changed the title add "cite" attribute to whitelist for <blockquote> elements (fixes #6084) add "cite" attribute to whitelist for <blockquote> elements Feb 23, 2016

@AprilArcus AprilArcus force-pushed the AprilArcus:cite-attribute branch from fd1b825 to 39c597f Feb 23, 2016

@jimfb

This comment has been minimized.

Copy link
Contributor

commented Feb 24, 2016

jimfb added a commit that referenced this pull request Feb 24, 2016

Merge pull request #6094 from AprilArcus/cite-attribute
add "cite" attribute to whitelist for <blockquote> elements

@jimfb jimfb merged commit 308badb into facebook:master Feb 24, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jimfb

This comment has been minimized.

Copy link
Contributor

commented Feb 24, 2016

Thanks @AprilArcus!

@zpao

This comment has been minimized.

Copy link
Member

commented Feb 25, 2016

Thanks @AprilArcus! To answer your questions:

  1. We test these manually. Our automated tests use jsdom which is not 100% consistent with browsers.
  2. We've thought about making it scoped per node type but our ultimate goal has been to get rid of this whitelist entirely so we haven't invested in the idea (though there's a PR proposal doing that somewhere)

@renovate renovate bot referenced this pull request Feb 2, 2018

Open

Update dependency react to v0.14.9 #29

0 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.