Fix shouldUpdateReactComponent not considering props.key #711
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently @spicyj already has a pending PR for this that should be considered instead, #591.
key
is currently only obeyed by descendants of the root-node, the root-node itself does not obeykey
. This simple fix ensures that it works on the root-node as well.I would consider this a bug and speaking hastily to petehunt, he seemed to agree:
<@petehunt> yeah i think that would be a bug
My personal motivation for this is my
<swf>
-component that I will be releasing, it requires this to support changingsrc
at run-time (although other workarounds do exist). In my opinion, there's no reason why the root-node should be any different from the other children in this regard.