Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Build renderers into their individual npm packages #7168
This copies modules into three separate packages instead of putting it all in React.
The overlap in shared folders gets duplicated.
This allows the isomorphic package to stay minimal. It can also be used as a direct dependency without much risk.
This also allow us to ship versions to each renderer independently and we can ship renderers without updating the main react package dependency.
The next step would be to flat bundle these.
One benefit of this is that we don't actually have to use
As long as we use the
I'm still a bit skeptical of the copying strategy because it delays use of smart build systems (optimizing compilers like closure compiler, emscripten for hot paths, Reason, etc) if we're limited to also getting those systems integrated into the downstreams.
We might want to build the fiber renderer as its own standalone npm package that anyone can use to build a renderer. That would be great for React ART, and therefore anyone building a renderer in an external repo.
We only really need the duplication for the existing stateful DI.