-
Notifications
You must be signed in to change notification settings - Fork 46.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass shouldHaveDebugID flag to instantiateComponent #7193
Conversation
|
||
var Anon = React.createClass({displayName: null, render: () => null}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes are just indentation. I moved an existing test into a common describe
and added two more tests based on the issue reports.
Is it possible to just pass in a flag to instantiateReactComponent instead for whether to skip assigning a debug ID? That feels nicer than ad hoc fields. |
Updated. |
Can you pass |
I think I did that, did I miss a callsite? |
More specifically:
|
Oh weird, I think it wasn't showing me all the files. Looks great. |
* Add failing tests for facebook#7187 and facebook#7190 * Pass shouldHaveDebugID flag to instantiateComponent This allows us to remove a hack that was added in facebook#6770 and caused facebook#7187 and facebook#7190. * Move logic for choosing whether to use debugID outside instantiate
This allows us to remove a hack that was added in #6770.
That hack caused #7187 and #7190 so this is an alternative fix to the same problem.