Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fiber feature flag for ReactDOMProduction-test #8451

Merged
merged 1 commit into from
Nov 29, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions scripts/fiber/tests-failing.txt
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ src/renderers/art/__tests__/ReactART-test.js
* resolves refs before componentDidMount
* resolves refs before componentDidUpdate

src/renderers/dom/__tests__/ReactDOMProduction-test.js
* should throw with an error code in production

src/renderers/dom/shared/__tests__/ReactDOM-test.js
* throws in render() if the mount callback is not a function
* throws in render() if the update callback is not a function
Expand Down
1 change: 0 additions & 1 deletion scripts/fiber/tests-passing.txt
Original file line number Diff line number Diff line change
Expand Up @@ -488,7 +488,6 @@ src/renderers/dom/__tests__/ReactDOMProduction-test.js
* should use prod React
* should handle a simple flow
* should call lifecycle methods
* should throw with an error code in production

src/renderers/dom/fiber/__tests__/ReactDOMFiber-test.js
* should render strings as children
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,9 @@ describe('ReactPropTypesProduction', function() {
beforeEach(function() {
__DEV__ = false;
oldProcess = process;
global.process = {env: {NODE_ENV: 'production'}};
global.process = {
env: Object.assign({}, process.env, {NODE_ENV: 'production'}),
};

jest.resetModuleRegistry();
PropTypes = require('ReactPropTypes');
Expand Down
4 changes: 3 additions & 1 deletion src/renderers/dom/__tests__/ReactDOMProduction-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,9 @@ describe('ReactDOMProduction', () => {
beforeEach(() => {
__DEV__ = false;
oldProcess = process;
global.process = {env: {NODE_ENV: 'production'}};
global.process = {
env: Object.assign({}, process.env, {NODE_ENV: 'production'}),
};

jest.resetModuleRegistry();
React = require('React');
Expand Down
4 changes: 3 additions & 1 deletion src/renderers/shared/utils/__tests__/ReactErrorUtils-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,9 @@ describe('ReactErrorUtils', () => {
);
__DEV__ = false;
var oldProcess = process;
global.process = {env: {NODE_ENV: 'production'}};
global.process = {
env: Object.assign({}, process.env, {NODE_ENV: 'production'}),
};
jest.resetModuleRegistry();
ReactErrorUtils = require('ReactErrorUtils');
expect(ReactErrorUtils.invokeGuardedCallback).toEqual(
Expand Down