New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate React.createMixin #8853

Merged
merged 4 commits into from Jan 24, 2017

Conversation

Projects
None yet
4 participants
@aweary
Member

aweary commented Jan 24, 2017

One step towards #8852. This also adds tests for the deprecation warning, along with the React.__spread method. I didn't see a good place to stick these tests, so I just created a new __tests__ folder in src/isomorphic.

aweary added some commits Jan 24, 2017

Deprecate React.createMixin
This API was never fully implemented. Since mixins are no longer considered part of the future React API, it will be removed.

@gaearon gaearon referenced this pull request Jan 24, 2017

Closed

React 16 Umbrella ☂️ (and 15.5) #8854

117 of 120 tasks complete
@gaearon

Please merge after CI passes.

@aweary aweary added this to the 15-lopri milestone Jan 24, 2017

@aweary aweary merged commit 2be0583 into facebook:master Jan 24, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@aweary aweary deleted the aweary:remove-create-mixin branch Jan 24, 2017

@sophiebits

This comment has been minimized.

Show comment
Hide comment
@sophiebits

sophiebits Jan 24, 2017

Member

CI is failing, looks related to this:

https://circleci.com/gh/facebook/react/1082

Member

sophiebits commented Jan 24, 2017

CI is failing, looks related to this:

https://circleci.com/gh/facebook/react/1082

@gaearon

This comment has been minimized.

Show comment
Hide comment
@gaearon

gaearon Jan 24, 2017

Member

I don't think so. It seems like this was broken by #8858: we didn't run the tests in Fiber mode and one of the tests seems to assert a different warning message.

Member

gaearon commented Jan 24, 2017

I don't think so. It seems like this was broken by #8858: we didn't run the tests in Fiber mode and one of the tests seems to assert a different warning message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment