New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds CSS Grid properties to list of unitless numbers #9185

Merged
merged 1 commit into from Apr 20, 2017

Conversation

Projects
None yet
4 participants
@ericsakmar
Contributor

ericsakmar commented Mar 15, 2017

Adds the following CSS Grid properties to the list of unitless numbers:

  • gridColumnStart
  • gridColumnEnd
  • gridColumnSpan (ie/ms only)
  • gridRowStart
  • gridRowEnd
  • gridRowSpan (ie/ms only)

Without these values in the list, the code appends a px, which is not valid for these properties.

@gaearon

This comment has been minimized.

Show comment
Hide comment
@gaearon

gaearon Apr 18, 2017

Member

Is this list exhaustive?

Member

gaearon commented Apr 18, 2017

Is this list exhaustive?

@flarnie flarnie referenced this pull request Apr 18, 2017

Closed

React 15.6 Umbrella #9398

41 of 49 tasks complete
@ericsakmar

This comment has been minimized.

Show comment
Hide comment
@ericsakmar

ericsakmar Apr 18, 2017

Contributor

It's exhaustive to the CSS grid spec, but not necessarily exhaustive to other newer unitless properties outside of that spec.

Contributor

ericsakmar commented Apr 18, 2017

It's exhaustive to the CSS grid spec, but not necessarily exhaustive to other newer unitless properties outside of that spec.

@flarnie flarnie self-assigned this Apr 20, 2017

@flarnie

This comment has been minimized.

Show comment
Hide comment
@flarnie

flarnie Apr 20, 2017

Contributor

Initially my questions were:

  1. Is it too soon to add CSS Grid syntax to React? What if the spec changes?
  2. Does this miss any other CSS Grid properties?

Clearly though if we already support gridColumn and gridRow then we should support the more specific grid properties too. And it looks like this does not miss any other non-px grid properties.

Thanks for submitting this @ericsakmar!

Contributor

flarnie commented Apr 20, 2017

Initially my questions were:

  1. Is it too soon to add CSS Grid syntax to React? What if the spec changes?
  2. Does this miss any other CSS Grid properties?

Clearly though if we already support gridColumn and gridRow then we should support the more specific grid properties too. And it looks like this does not miss any other non-px grid properties.

Thanks for submitting this @ericsakmar!

@flarnie flarnie merged commit 6488229 into facebook:master Apr 20, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@flarnie flarnie added this to the 15.6 milestone Apr 20, 2017

flarnie added a commit to flarnie/react that referenced this pull request Jun 7, 2017

@renovate renovate bot referenced this pull request Feb 2, 2018

Open

Update dependency react to v16 #29

mgol added a commit to mgol/react that referenced this pull request Sep 4, 2018

gaearon added a commit that referenced this pull request Sep 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment