-
Notifications
You must be signed in to change notification settings - Fork 45.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tests to not warn due to moved PropTypes and shallowRenderer #9486
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for working through these!
This happens when I run |
I'm guessing
means "while executing spawnSync", a ENOENT ("Error NO ENTry", the code for "No such file or directory") error was hit when looking for |
Thanks - that makes sense. That file is indeed missing, and does not appear after |
Prettier wasn't used in 15. Was added recently. |
I'm pushing the prettier diff separately - will update this again in a min. Thanks everyone for helping. :) |
4c0ec73
to
efa5a1b
Compare
FYI here is the plan;
|
We added some warnings in v15.5 for calling `React.PropTypes` and calling the shallow renderer from the wrong place. These warnings were causing test failures, and now they are fixed. Most of these were for the `React.PropTypes` change.
@flarnie Thanks for getting 15 branch back into shape 👍 |
efa5a1b
to
7de83b7
Compare
**what is the change?:** Updated 'PropTypes' and 'shallow renderer' syntax in a couple more places to get tests passing. **why make this change?:** In order to verify any changes to the 15.6 and 15.* branches in general we should have tests passing. **test plan:** `npm run test` **issue:** facebook#9410
7de83b7
to
1af5590
Compare
…acebook#9486) * Update tests to not warn due to moved PropTypes and shallowRenderer We added some warnings in v15.5 for calling `React.PropTypes` and calling the shallow renderer from the wrong place. These warnings were causing test failures, and now they are fixed. Most of these were for the `React.PropTypes` change. * tweak from running prettier * Final tweaks to get tests passing **what is the change?:** Updated 'PropTypes' and 'shallow renderer' syntax in a couple more places to get tests passing. **why make this change?:** In order to verify any changes to the 15.6 and 15.* branches in general we should have tests passing. **test plan:** `npm run test` **issue:** facebook#9410
This will unblock continued work on the 15.6-dev branch.
We added some warnings in v15.5 for calling
React.PropTypes
andcalling the shallow renderer from the wrong place. These warnings were
causing test failures, and now they are fixed.
Most of these were for the
React.PropTypes
change.