-
Notifications
You must be signed in to change notification settings - Fork 45.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove createClass, PropTypes, DOM factories, and createMixin from React object #9788
Conversation
d5188d2
to
a26fcbf
Compare
I was just making an issue to track this, and then saw that you were already working on it. Nice. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love the sound of code being deleted~
}, | ||
"react.production.min.js (UMD_PROD)": { | ||
"size": 15753, | ||
"gzip": 5824 | ||
"size": 7756, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚡️ 🎸 🥇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really sure I can approve this, but it makes me happy!
Internal callers in www should be patched up, and we'll need to codemod fbsource soon anyway. |
There's still a few callers in www which I'll fix internally before merging.
We also have some RN code that still uses them but plan to either codemod it or shim it for the time being. In either case this will only matter after we cut another
react
package and update internal RN code to use it, which probably won't happen before codemodding.