Fix mac build #691
Closed
Fix mac build #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 8, 2022 18:14
For some reason, building on a mac leads to std::unsorted_map not being found unless you include <unordered_map>.
GoogleTest has a build issue on macos where it does not properly set C++ to the 17 standard and so has compilation failures. The fix is to explicitly tell the gtest compilation to use "--std=gnu++17" although this may not be the best fix possible.
|
@NTillmann has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were more mac-specific build breakages that needed to be fixed.
One was a relatively simple need to explicitly include
<unordered_map>due to mac being weird.The other was a breakage in gtest which does not compile in macos due to an inability in
cmaketo properly set C++17. The fix was to explicitly addCXXFLAGS="-std=gnu++17"to force proper compilation, although it may not be a clean fix since the comments indicate that the maintainers wanted to keepCXXFLAGSempty.