Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize functions for checking Java identifiers #859

Closed
wants to merge 1 commit into from
Closed

Reorganize functions for checking Java identifiers #859

wants to merge 1 commit into from

Conversation

wsanville
Copy link
Contributor

Differential Revision: D56921682

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56921682

@wsanville @facebook-github-bot
Reorganize functions for checking Java identifiers (facebook#859)
c8e8eaf 
Summary:


I made the misguided choice of refactoring and reusing some methods from ProguardLexer.cpp, and broke the build on Windows for a reason I cannot understand (`TokenType` enum values in ProguardLexer.h somehow were not parsed as valid anymore???? Dunno).

Revert that part of the change, and instead move the useful methods from ProguardLexer to the `java_names` namespace in DexUtil.h.

Differential Revision: D56921682
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56921682

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 18bf461.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed fb-exported Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wsanville @facebook-github-bot