Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize functions for checking Java identifiers #859

Closed
wants to merge 1 commit into from
Closed

Reorganize functions for checking Java identifiers #859

wants to merge 1 commit into from
+46 −43

Commits on May 3, 2024

  1. Reorganize functions for checking Java identifiers (facebook#859) 

    Summary:


I made the misguided choice of refactoring and reusing some methods from ProguardLexer.cpp, and broke the build on Windows for a reason I cannot understand (`TokenType` enum values in ProguardLexer.h somehow were not parsed as valid anymore???? Dunno).

Revert that part of the change, and instead move the useful methods from ProguardLexer to the `java_names` namespace in DexUtil.h.

Differential Revision: D56921682
    @wsanville @facebook-github-bot
    wsanville authored and facebook-github-bot committed May 3, 2024
    Configuration menu
    Copy the full SHA
    c8e8eaf View commit details
    Browse the repository at this point in the history