Setup a Lerna monorepo #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andarist
commented
Jul 22, 2017
| language: node_js | ||
| node_js: | ||
| - "8" | ||
| - "7" | ||
| - "6" | ||
| - "5" | ||
| - "4" | ||
| - "0.12" |
There was a problem hiding this comment.
those got removed as unsupported by lerna
Andarist
commented
Jul 22, 2017
| @@ -22,6 +22,6 @@ | |||
| "babel-plugin-transform-es2015-block-scoping": "^6.18.0", | |||
| "babel-plugin-transform-es2015-classes": "^6.18.0", | |||
| "babel-plugin-transform-es2015-for-of": "^6.18.0", | |||
| "regenerator-transform": "^0.9.3" | |||
| "regenerator-transform": "^0.9.12" | |||
There was a problem hiding this comment.
dep updated to match ./packages/regenerator-transform
Andarist
commented
Jul 22, 2017
| "test": "node test/run.js" | ||
| }, | ||
| "dependencies": { | ||
| "babel-core": "^6.18.2", | ||
| "babel-plugin-syntax-async-functions": "^6.13.0", | ||
| "babel-plugin-syntax-async-generators": "^6.13.0", | ||
| "babel-plugin-transform-es2015-arrow-functions": "^6.8.0", |
There was a problem hiding this comment.
all of those new deps here got hoisted manually by me from each package, it is supposed to make process of bootstrapping + hoisting faster (lerna)
Andarist
commented
Jul 22, 2017
| "lerna": "2.0.0", | ||
| "packages": [ | ||
| "packages/*", | ||
| "." |
There was a problem hiding this comment.
root directory could be removed and root's package.json marked as "private": true as this root "package" seems to be deprecated anyway
|
Awesome, glad to see this happen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes #260