Handle .throw method in delegate generator. Fix #80. #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -74,6 +74,9 @@ | |||
| if (delegate) { | |||
| try { | |||
| var info = delegate.generator[method](arg); | |||
| // Delegate generator ran and handled it's own exceptions so | |||
| // regardless of what the method is we continue as if it is "next". | |||
| method = "next"; | |||
There was a problem hiding this comment.
Do we need to set arg = void 0 here too? Or is the exception that was supposed to be thrown still of any interest?
There was a problem hiding this comment.
yeah I think we can do away with it. will update.
benjamn
added a commit
that referenced
this pull request
Feb 2, 2014
Handle .throw method in delegate generator. Fixes #80.
|
thank you!!! |
|
Yeah, @amasad deserves many thanks for finding a really elegant fix for this problem! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure the outer generator won't dispatch the same exception handled by delegate generator (initiated by
.throw)