Make tests pass using Node 5 / NPM 3 #832 #840

raineroviir · 2016-02-15T07:16:22Z

No description provided.

Make tests pass using Node 5 / NPM 3 facebook#832 Make tests pass using Node 5 / NPM 3 facebook#832 Make tests pass using Node 5 / NPM 3 facebook#832

…iner

raineroviir · 2016-02-15T21:14:18Z

ugh I'm having some trouble merging all these commits .. I might give up and submit a new pr

kassens · 2016-02-17T22:40:54Z

No worries, when we merge this, it will all be combined into one commit.

raineroviir · 2016-02-18T02:24:53Z

Ok cool thanks!
On Wed, Feb 17, 2016 at 2:41 PM Jan Kassens notifications@github.com
wrote:

No worries, when we merge this, it will all be combined into one commit.

—
Reply to this email directly or view it on GitHub
#840 (comment).

kassens · 2016-02-18T19:22:08Z

package.json

-      "<rootDir>/node_modules/react/",
-      "<rootDir>/node_modules/react-dom/",
-      "<rootDir>/node_modules/react-static-container/"
+      "<rootDir>/node_modules/(?!(fbjs/lib/ErrorUtils.js$|fbjs/lib/fetch.js$|fbjs/lib/fetchWithRetries.js$))"


If you keep the deleted lines here and just have 2 patterns and add 4 and 5 to the travis config, do the tests pass in both environments? It'd be nice to work in both if it's just adding the new patterns instead of replacing them.

Is there something that makes it difficult to keep the npm 2 patterns in this file?

The only difficulty is I don't know how to. Let me see what I can do

kassens · 2016-02-19T18:33:49Z

This is great, thanks for taking the extra step for cross compatibility! Just one more thing

kassens · 2016-02-19T18:34:54Z

package.json

@@ -30,7 +30,8 @@
  "dependencies": {
    "babel-runtime": "5.8.24",
    "fbjs": "^0.7.0",
-    "react-static-container": "^1.0.0-alpha.1"
+    "react-static-container": "^1.0.0-alpha.1",
+    "babel-relay-plugin": "0.7.1"


I think the idea is that people would need to add babel-relay-plugin to their project with npm 3, so it should remain (just) a peer dependency. I'd love someone with more npm knowledge here..

cc @steveluscher

Edit: If the plugin isn't under dependencies, you have to manually install it with npm 3.
Which means npm test will fail in travis-ci since the plugin wasn't installed. You can see the failing tests above for one of my commits: https://travis-ci.org/facebook/relay/builds/109438390

Just guessing here, but should it maybe be in devDependencies in that case? It's needed to run the unit tests, but if you're using it in your own project, you should add it to your dependencies (to use it in your transform step).

I'm not sure, let me try it out
On Fri, Feb 19, 2016 at 6:28 PM Jan Kassens notifications@github.com
wrote:

In package.json
#840 (comment):

@@ -30,7 +30,8 @@
"dependencies": {
"babel-runtime": "5.8.24",
"fbjs": "^0.7.0",

"react-static-container": "^1.0.0-alpha.1"

"react-static-container": "^1.0.0-alpha.1",

"babel-relay-plugin": "0.7.1"

Just guessing here, but should it maybe be in devDependencies in that
case? It's needed to run the unit tests, but if you're using it in your own
project, you should add it to your dependencies (to use it in your
transform step).

—
Reply to this email directly or view it on GitHub
https://github.com/facebook/relay/pull/840/files#r53542588.

cpojer · 2016-02-20T05:12:52Z

fyi jest 0.9.0 (without the fb-suffix) will have fixed npm3 support in Jest. I'll try to get it out next week :)

raineroviir · 2016-02-20T07:09:47Z

OK great! I moved the babel-relay-plugin into devDeps and you were right @kassens!
Also, Travis-CI is failing a test that will be fixed in #810

cpojer · 2016-02-23T06:12:14Z

package.json

@@ -92,7 +93,8 @@
      "<rootDir>/node_modules/fbjs/lib/(?!(ErrorUtils.js$|fetch.js$|fetchWithRetries.js$))",
      "<rootDir>/node_modules/react/",
      "<rootDir>/node_modules/react-dom/",
-      "<rootDir>/node_modules/react-static-container/"
+      "<rootDir>/node_modules/react-static-container/",
+      "<rootDir>/node_modules/(?!(fbjs/lib/ErrorUtils.js$|fbjs/lib/fetch.js$|fbjs/lib/fetchWithRetries.js$))"


you should be able to revert this change once I update to jest 0.9.0-fb3.

Ok sure! I'll be awaiting jests 0.9.0-fb3 release

Summary:0.9.0-fb3 comes with all those sweet npm3 fixes. Also see #840 and #832. Tests are passing for me on node4 both with npm2 and npm3. See jestjs/jest@7b44ca0 and jestjs/jest@2d10421 cc kassens raineroviir Closes #877 Differential Revision: D2971806 fb-gh-sync-id: 85f2898f71df12eaf7f2b4bd6a2e641305453b45 shipit-source-id: 85f2898f71df12eaf7f2b4bd6a2e641305453b45

…iner

kassens · 2016-02-25T01:28:17Z

Looks like the flow fix didn't quite work. Sorry this is such a journey and thank you for keeping the updates coming!

raineroviir · 2016-02-25T01:34:38Z

Yeah! Its a big project, not easy! We can either ignore the 'base62' node_module or include it under Flow, in the flowconfig which one makes more sense? (Both would fix the travis error)

raineroviir · 2016-02-25T07:10:24Z

Getting this error on npm install:

Error: ModuleNotFoundError: Module not found: Error: Cannot resolve 'file' or 'directory' ./Set in /Users/raineroviir/relay/lib.

as well as this on npm test:

src/query/buildRQL.js:25
 25: const Set = require('Set');
                 ^^^^^^^^^^^^^^ Set. Required module not found
Found 1 error

Seems like ES6 Set isn't getting loaded?

josephsavona · 2016-02-25T17:16:05Z

@raineroviir that's from a commit of mine yesterday, i'm trying to figure out why Set isn't available and will report back here.

josephsavona · 2016-02-25T17:41:55Z

see #881 for the fix to the missing Set module

raineroviir · 2016-02-25T17:44:00Z

Thanks Mr. Savona

kassens · 2016-02-26T02:50:04Z

Awesome, great to see it finally all working 👍

@facebook-github-bot import

facebook-github-bot · 2016-02-26T02:54:20Z

Thanks for importing. If you are an FB employee go to Phabricator to review.

cpojer · 2016-02-26T04:24:58Z

Yes! This is great.

raineroviir · 2016-02-26T04:34:36Z

Glad to help =)

Make tests pass using Node 5 / NPM 3 facebook#832

471e489

facebook-github-bot added the CLA Signed label Feb 15, 2016

rainer oviir added 6 commits February 15, 2016 11:57

Make tests pass using Node 5 / NPM 3 facebook#832

6f19ad7

Make tests pass using Node 5 / NPM 3 facebook#832

139e7d3

Make tests pass using Node 5 / NPM 3 facebook#832

7dc2ada

Make tests pass using Node 5 / NPM 3 facebook#832

b7e5fea

Make tests pass using Node 5 / NPM 3 facebook#832

9050c55

Make tests pass using Node 5 / NPM 3 facebook#832 Make tests pass using Node 5 / NPM 3 facebook#832 Make tests pass using Node 5 / NPM 3 facebook#832

Merge branch 'rainer' of https://github.com/raineroviir/relay into ra…

8735f6d

…iner

kassens reviewed Feb 18, 2016
View reviewed changes

rainer oviir added 2 commits February 18, 2016 18:27

make npm 4 and 5 work

1629a6f

fix for npm 4 and 5 compatibility

b65ce82

kassens reviewed Feb 19, 2016
View reviewed changes

babel-relay-plugin under devDeps

703aaa9

cpojer reviewed Feb 23, 2016
View reviewed changes

cpojer mentioned this pull request Feb 24, 2016

Update Jest to work with npm3. #877

Closed

fix flow error with base62 during npm test

2ad94ed

rainer oviir added 4 commits February 24, 2016 12:08

Merge branch 'rainer' of https://github.com/raineroviir/relay into ra…

e5e762a

…iner

Merge remote-tracking branch 'upstream/master' into rainer

d94114d

fix base62 error for flow and add node 5 to travis

ff4d438

removed extraneous changes

306d569

rainer oviir added 4 commits February 24, 2016 17:46

fix base62 error

2eff6a0

fix flow error for node_modules/util

441a8d7

fix util flow error

9d1ce5c

Merge remote-tracking branch 'upstream/master' into rainer

e6ca07a

rainer oviir added 3 commits February 25, 2016 14:48

Merge remote-tracking branch 'upstream/master' into rainer

a918aa1

fix flow errors

2380ea1

fix flow errors

ceffba9

ghost closed this in 0acd8e2 Feb 26, 2016

ebarahona mentioned this pull request Jun 22, 2022

[Snyk] Fix for 21 vulnerabilities ebarahona/relay#52

Open

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make tests pass using Node 5 / NPM 3 #832 #840

Make tests pass using Node 5 / NPM 3 #832 #840

raineroviir commented Feb 15, 2016

raineroviir commented Feb 15, 2016

kassens commented Feb 17, 2016

raineroviir commented Feb 18, 2016

kassens Feb 18, 2016

raineroviir Feb 18, 2016

kassens commented Feb 19, 2016

kassens Feb 19, 2016

raineroviir Feb 19, 2016

kassens Feb 20, 2016

raineroviir Feb 20, 2016

cpojer commented Feb 20, 2016

raineroviir commented Feb 20, 2016

cpojer Feb 23, 2016

raineroviir Feb 23, 2016

kassens commented Feb 25, 2016

raineroviir commented Feb 25, 2016

raineroviir commented Feb 25, 2016

josephsavona commented Feb 25, 2016

josephsavona commented Feb 25, 2016

raineroviir commented Feb 25, 2016

kassens commented Feb 26, 2016

facebook-github-bot commented Feb 26, 2016

cpojer commented Feb 26, 2016

raineroviir commented Feb 26, 2016

Make tests pass using Node 5 / NPM 3 #832 #840

Make tests pass using Node 5 / NPM 3 #832 #840

Conversation

raineroviir commented Feb 15, 2016

raineroviir commented Feb 15, 2016

kassens commented Feb 17, 2016

raineroviir commented Feb 18, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kassens commented Feb 19, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cpojer commented Feb 20, 2016

raineroviir commented Feb 20, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kassens commented Feb 25, 2016

raineroviir commented Feb 25, 2016

raineroviir commented Feb 25, 2016

josephsavona commented Feb 25, 2016

josephsavona commented Feb 25, 2016

raineroviir commented Feb 25, 2016

kassens commented Feb 26, 2016

facebook-github-bot commented Feb 26, 2016

cpojer commented Feb 26, 2016

raineroviir commented Feb 26, 2016