-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make tests pass using Node 5 / NPM 3 #832 #840
Changes from 10 commits
471e489
6f19ad7
139e7d3
7dc2ada
b7e5fea
9050c55
8735f6d
1629a6f
b65ce82
703aaa9
2ad94ed
e5e762a
d94114d
ff4d438
306d569
2eff6a0
441a8d7
9d1ce5c
e6ca07a
a918aa1
2380ea1
ceffba9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,6 +2,7 @@ | |
language: node_js | ||
node_js: | ||
- '4' | ||
- '5' | ||
env: | ||
- TEST_DIR=. | ||
- TEST_DIR=scripts/babel-relay-plugin | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -40,6 +40,7 @@ | |
"babel": "^5.8.25", | ||
"babel-core": "^5.8.25", | ||
"babel-eslint": "^4.1.1", | ||
"babel-relay-plugin": "0.7.1", | ||
"del": "^1.2.0", | ||
"eslint": "^1.3.1", | ||
"eslint-plugin-react": "^3.3.1", | ||
|
@@ -92,7 +93,8 @@ | |
"<rootDir>/node_modules/fbjs/lib/(?!(ErrorUtils.js$|fetch.js$|fetchWithRetries.js$))", | ||
"<rootDir>/node_modules/react/", | ||
"<rootDir>/node_modules/react-dom/", | ||
"<rootDir>/node_modules/react-static-container/" | ||
"<rootDir>/node_modules/react-static-container/", | ||
"<rootDir>/node_modules/(?!(fbjs/lib/ErrorUtils.js$|fbjs/lib/fetch.js$|fbjs/lib/fetchWithRetries.js$))" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If you keep the deleted lines here and just have 2 patterns and add Is there something that makes it difficult to keep the npm 2 patterns in this file? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The only difficulty is I don't know how to. Let me see what I can do There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. you should be able to revert this change once I update to jest 0.9.0-fb3. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ok sure! I'll be awaiting jests 0.9.0-fb3 release |
||
] | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,6 +4,7 @@ | |
|
||
[include] | ||
../node_modules/ | ||
../../../node_modules/util/ | ||
|
||
[libs] | ||
../interfaces | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also this one. I'll update the preprocessor in my diff so this shouldn't be needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found that travis-ci will not green light the PR in npm3 since it no longer looks at peer dependencies, so I threw it in devDeps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just updated the path here: https://github.com/facebook/relay/blob/master/scripts/jest/preprocessor.js#L67 to the one in
scripts
and that worked for me.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im not able to repro passing tests without having babel-relay-plugin in devdeps or deps. What do you mean by
scripts
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updates the path in https://github.com/facebook/relay/blob/master/scripts/jest/preprocessor.js#L66 to https://github.com/facebook/relay/blob/master/scripts/babel-relay-plugin/package.json and that made all the tests pass :)