Skip to content

Commit

Permalink
Add Status check enforcement for unit tests (#7464)
Browse files Browse the repository at this point in the history
Summary:
Add status check for unit tests : block_based_filter_block_test, block_fetcher_test, full_filter_block_test and partitioned_filter_block_test

Pull Request resolved: #7464

Reviewed By: zhichao-cao

Differential Revision: D24011309

Pulled By: akankshamahajan15

fbshipit-source-id: d814803f94e8bb8b811ef170d20b22d52c1a3ff2
  • Loading branch information
akankshamahajan15 authored and facebook-github-bot committed Sep 30, 2020
1 parent ddbc5da commit 5997f6b
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
4 changes: 4 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -647,6 +647,10 @@ ifdef ASSERT_STATUS_CHECKED
merge_helper_test \
memtable_list_test \
flush_job_test \
block_based_filter_block_test \
block_fetcher_test \
full_filter_block_test \
partitioned_filter_block_test \

ifeq ($(USE_FOLLY_DISTRIBUTED_MUTEX),1)
TESTS_PASSING_ASC += folly_synchronization_distributed_mutex_test
Expand Down
5 changes: 3 additions & 2 deletions table/block_fetcher_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -295,8 +295,9 @@ class BlockFetcherTest : public testing::Test {
uint64_t file_size = 0;
ASSERT_OK(env_->GetFileSize(file->file_name(), &file_size));
IOOptions opts;
ReadFooterFromFile(opts, file, nullptr /* prefetch_buffer */, file_size,
footer, kBlockBasedTableMagicNumber);
ASSERT_OK(ReadFooterFromFile(opts, file, nullptr /* prefetch_buffer */,
file_size, footer,
kBlockBasedTableMagicNumber));
}

// NOTE: compression_type returns the compression type of the fetched block
Expand Down

0 comments on commit 5997f6b

Please sign in to comment.