expose mode option to Rate Limiter via C API (#12259)

Summary: addresses #12220 to allow rate limiting compaction but not flushes Pull Request resolved: #12259 Reviewed By: jaykorean Differential Revision: D52965342 Pulled By: ajkr fbshipit-source-id: 38566d9ac75c932c63e10cc53796fab0e46e3b2e
facebook · Jan 22, 2024 · e572ae9 · e572ae9
1 parent 4b684e9
commit e572ae9
Show file tree

Hide file tree

Showing 5 changed files with 23 additions and 3 deletions.
diff --git a/db/c.cc b/db/c.cc
@@ -4005,6 +4005,16 @@ rocksdb_ratelimiter_t* rocksdb_ratelimiter_create_auto_tuned(
   return rate_limiter;
 }
 
+rocksdb_ratelimiter_t* rocksdb_ratelimiter_create_with_mode(
+    int64_t rate_bytes_per_sec, int64_t refill_period_us, int32_t fairness,
+    int mode, bool auto_tuned) {
+  rocksdb_ratelimiter_t* rate_limiter = new rocksdb_ratelimiter_t;
+  rate_limiter->rep.reset(
+      NewGenericRateLimiter(rate_bytes_per_sec, refill_period_us, fairness,
+                            static_cast<RateLimiter::Mode>(mode), auto_tuned));
+  return rate_limiter;
+}
+
 void rocksdb_ratelimiter_destroy(rocksdb_ratelimiter_t* limiter) {
   delete limiter;
 }

diff --git a/db/c_test.c b/db/c_test.c
@@ -718,6 +718,11 @@ int main(int argc, char** argv) {
   rocksdb_options_set_ratelimiter(options, rate_limiter);
   rocksdb_ratelimiter_destroy(rate_limiter);
 
+  rate_limiter = rocksdb_ratelimiter_create_with_mode(1000 * 1024 * 1024,
+                                                      100 * 1000, 10, 0, true);
+  rocksdb_options_set_ratelimiter(options, rate_limiter);
+  rocksdb_ratelimiter_destroy(rate_limiter);
+
   roptions = rocksdb_readoptions_create();
   rocksdb_readoptions_set_verify_checksums(roptions, 1);
   rocksdb_readoptions_set_fill_cache(roptions, 1);

diff --git a/include/rocksdb/c.h b/include/rocksdb/c.h
@@ -1684,6 +1684,10 @@ extern ROCKSDB_LIBRARY_API rocksdb_ratelimiter_t*
 rocksdb_ratelimiter_create_auto_tuned(int64_t rate_bytes_per_sec,
                                       int64_t refill_period_us,
                                       int32_t fairness);
+extern ROCKSDB_LIBRARY_API rocksdb_ratelimiter_t*
+rocksdb_ratelimiter_create_with_mode(int64_t rate_bytes_per_sec,
+                                     int64_t refill_period_us, int32_t fairness,
+                                     int mode, bool auto_tuned);
 extern ROCKSDB_LIBRARY_API void rocksdb_ratelimiter_destroy(
     rocksdb_ratelimiter_t*);
 

diff --git a/include/rocksdb/rate_limiter.h b/include/rocksdb/rate_limiter.h
@@ -26,9 +26,9 @@ class RateLimiter {
   };
 
   enum class Mode {
-    kReadsOnly,
-    kWritesOnly,
-    kAllIo,
+    kReadsOnly = 0,
+    kWritesOnly = 1,
+    kAllIo = 2,
   };
 
   // For API compatibility, default to rate-limiting writes only.

diff --git a/unreleased_history/public_api_changes/expose_mode_option_rate_limiter_via_c_api.md b/unreleased_history/public_api_changes/expose_mode_option_rate_limiter_via_c_api.md
@@ -0,0 +1 @@
+Exposed mode option to Rate Limiter via c api.