Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to add TransactionDB and OptimisticTransactionDB to rockdbjni #1151

Closed
Kangmo opened this issue Jun 4, 2016 · 10 comments
Closed

Request to add TransactionDB and OptimisticTransactionDB to rockdbjni #1151

Kangmo opened this issue Jun 4, 2016 · 10 comments

Comments

@Kangmo
Copy link
Contributor

Kangmo commented Jun 4, 2016

Hi,

I am assuming that these two classes are missing in rocksdbjni.
It would be great if I can achieve atomicity of my transaction using either TransactionDB or OptimisticTransactionDB.

I request to add these two classes to rocksdbjni.
It would be great if you have any planned release day for the new rocksdbjni with these (or one of these) classes.

RocksDB rocks!!

@adamretter
Copy link
Collaborator

Hi @Kangmo I am already working on this and hope to have something in the next week or two.

@Kangmo
Copy link
Contributor Author

Kangmo commented Jun 4, 2016

Thanks Adam, that is great news!

2016년 6월 4일 토요일, Adam Retternotifications@github.com님이 작성한 메시지:

Hi @Kangmo https://github.com/Kangmo I am already working on this and
hope to have something in the next week or two.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1151 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAfJPyAfWyTyQwsPDVG4tw_NWB0HwhI6ks5qIVrHgaJpZM4IuFRw
.

@Kangmo
Copy link
Contributor Author

Kangmo commented Jun 5, 2016

Hi Adam, is there a branch that I can test the two classes before the release? It would be great if there is any to try out these classes.

Thanks for providing two classes in advance.

@wicknicks
Copy link

wicknicks commented Jun 16, 2016

Hi @adamretter, any progress on this feature? Would love to test it out on a project I am working on. Thanks very much.

@Kangmo
Copy link
Contributor Author

Kangmo commented Jul 2, 2016

Hi @adamretter, I also would love to test it out, and waiting for this feature to keep RocksDB data consistent in my project, ScaleChain.
Thanks in advance for your effort on this issue, again.

@adamretter
Copy link
Collaborator

adamretter commented Jul 2, 2016

I am working on it. It's just taking a while I am afraid.

The WIP is visible here https://github.com/adamretter/rocksdb/tree/java-transactions

@Kangmo
Copy link
Contributor Author

Kangmo commented Aug 8, 2016

Hi @adamretter, thanks for the update.

I have some questions on the transaction feature.
Just out of curiosity, does a transaction keep locks on keys?
(Sorry I did not investigate the underlying C++ implementation)

Example>
(1) Transaction A updates key1
(2) Transaction B updates key1 before Transaction A ends

Does transaction B wait for the lock on key1 held by Transaction A?
Does it support deadlock detection?
Does it support range rocks, or different kinds of isolation levels?
Are all four ACID properties supported?

@adamretter
Copy link
Collaborator

adamretter commented Aug 19, 2016

Duplicate of #697

@adamretter
Copy link
Collaborator

@Kangmo You are best to look at the Transaction Samples: https://github.com/adamretter/rocksdb/tree/java-transactions/java/samples/src/main/java

@gfosco
Copy link
Contributor

gfosco commented Jan 10, 2018

Closing this via automation due to lack of activity. If discussion is still needed here, please re-open or create a new/updated issue.

@gfosco gfosco closed this as completed Jan 10, 2018
facebook-github-bot pushed a commit that referenced this issue Mar 2, 2018
Summary:
Closes #697
Closes #1151
Closes #1298

Differential Revision: D7131402

Pulled By: sagar0

fbshipit-source-id: bcd34ce95ed88cc641786089ff4232df7b2f089f
sagar0 pushed a commit that referenced this issue Mar 5, 2018
Summary:
Closes #697
Closes #1151
Closes #1298

Differential Revision: D7131402

Pulled By: sagar0

fbshipit-source-id: bcd34ce95ed88cc641786089ff4232df7b2f089f
sagar0 pushed a commit that referenced this issue Mar 15, 2018
Summary:
Closes #697
Closes #1151
Closes #1298

Differential Revision: D7131402

Pulled By: sagar0

fbshipit-source-id: bcd34ce95ed88cc641786089ff4232df7b2f089f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants