-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rocksdb fails to compile on x86 musl #12725
Comments
There was a related patch, but I couldn't accept it yet because there were a bunch of test failures: #12515 |
Hello @Kladki, Detail answer: For example Radek |
Hello @Kladki, Thank for quick response. I'm little confused with your build system. I can see that you use cmake to generate build configuration for ninja build. But it doesn't look like the ninja build is the one used for final compilation. It looks to me you are using our make file. Also if I check the build log you provided, I can still see the In you PR, I don't understand why did you deleted I don't think you need the patch for Radek |
It's fine anyways, I tried switching to plain old make and then everything started building properly.
18 Jun 2024 09:15:40 Radek Hubner ***@***.***>:
…
Hello @Kladki[https://github.com/Kladki],
Thank for quick response. I'm little confused with your build system. I can see that you use cmake to generate build configuration for ninja build. But it doesn't look like the ninja build is the one used for final compilation. It looks to me you are using our make file. Also if I check the build log you provided, I can still see[https://gitlab.alpinelinux.org/Kladky/aports/-/jobs/1408180#L224] the *-m=native* in *Cflags* flags.
In you PR, I don't understand why did you deleted *cmake --build build* link[https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/62513/diffs?commit_id=7545f9c053ea2816960b4e38030639c47bf094fd#cda118dd7d6b5cfef62690fdc80b1563d5a3628f_40_41]
I don't think you need the patch for *util/math.h* either. You just need to tell build system to compile with *PORTABLE=1* on x86 architectures.
Radek
—
Reply to this email directly, view it on GitHub[#12725 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/BFX23U6LVJJMKOJPYGUW7P3ZH7UCXAVCNFSM6AAAAABIUZ5T36VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZVGQ4DMNRXHA].
You are receiving this because you were mentioned.
[Tracking image][https://github.com/notifications/beacon/BFX23U4BUFE7PKBKQCOLXJDZH7UCXA5CNFSM6AAAAABIUZ5T36WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTUBVNFNM.gif]
Message ID: ***@***.***>
|
Expected behavior
Rocksdb compiles.
Actual behavior
Fails to compile, with the following error. With this patch we managed to get the error down to this, but we are not sure how to proceed from there.
Steps to reproduce the behavior
The text was updated successfully, but these errors were encountered: