Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update zlib to 1.2.10 #1769

Closed
min-mwei opened this issue Jan 12, 2017 · 4 comments
Closed

update zlib to 1.2.10 #1769

min-mwei opened this issue Jan 12, 2017 · 4 comments

Comments

@min-mwei
Copy link
Contributor

Looks zlib 1.2.8 is pulled from its site. So the build is now failing.

Simply replace 1.2.8 with 1.2.10 in the Makefile should fix it.
@yiwu-arbug
Copy link
Contributor

#1741 addresses it.

@min-mwei
Copy link
Contributor Author

Great.

Also, I think all the downloads in the Makefile should be removed because the "make" should just work locally. So I like the idea of having all related tar balls (snappy, zlib etc.) checked into the rocksdb repo.

My two cents.

@adamretter
Copy link
Collaborator

@yiwu-arbug I don't think you should put these in the rocks repo. Better to download with checksums IMHO.

@yiwu-arbug
Copy link
Contributor

@adamretter sounds good.

@adamretter adamretter mentioned this issue Feb 11, 2017
Closed
facebook-github-bot pushed a commit that referenced this issue Feb 13, 2017
@adamretter @facebook-github-bot
Update static library versions and add checksums
0227c16 
Summary:
The previous version of zlib is no longer available. I have also updated the versions of the other static libraries and added checkum checks for the downloads; This is related to #1769
Closes #1863

Differential Revision: D4550742

Pulled By: yiwu-arbug

fbshipit-source-id: 4414150
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@adamretter @yiwu-arbug @min-mwei