Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RocksDB blog atom feed does not validate #4387

Closed
theimpostor opened this issue Sep 18, 2018 · 2 comments
Closed

RocksDB blog atom feed does not validate #4387

theimpostor opened this issue Sep 18, 2018 · 2 comments
Assignees
@gfosco

Comments

@theimpostor
Copy link

Note: Please use Issues only for bug reports. For questions, discussions, feature requests, etc. post to dev group: https://www.facebook.com/groups/rocksdb.dev

Expected behavior

RocksDB blog feed (http://rocksdb.org/feed.xml) is valid

Actual behavior

The feed does not validate:

https://validator.w3.org/feed/check.cgi?url=https%3A%2F%2Frocksdb.org%2Fblog%2F

Steps to reproduce the behavior

Try to add http://rocksdb.org/feed.xml to Mozilla Thunderbird feed reader.

Errors presented by w3c validator:

This feed does not validate.

line 7, column 11: link must be a full and valid URL: / [help]

    <link>/</link>
           ^
In addition, interoperability with the widest range of feed readers could be improved by implementing the following recommendation.

line 134, column 0: description should not contain relative URL references: /static/images/data-block-hash-index/block-format-binary-seek.png (8 occurrences) [help]

</description>
@ajkr
Copy link
Contributor

ajkr commented Sep 18, 2018

Perhaps @gfosco would be interested in looking at this?

@gfosco gfosco self-assigned this Sep 18, 2018
@gfosco gfosco mentioned this issue Sep 18, 2018
Closed
facebook-github-bot pushed a commit that referenced this issue Sep 18, 2018
@gfosco @facebook-github-bot
Fix issue with docs/feed.xml validation (#4392)
886766c 
Summary:
Per #4387 this should address the validation error with the link tag.  This is a quick fix, a future iteration could significantly upgrade the jekyll integration.
Pull Request resolved: #4392

Differential Revision: D9923643

Pulled By: gfosco

fbshipit-source-id: e7ed478e55c907add8319290326540e6e44fc0d6
@gfosco
Copy link
Contributor

gfosco commented Sep 18, 2018

Thanks for reporting this. The w3 validator now reports the feed is valid.

@gfosco gfosco closed this as completed Sep 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gfosco gfosco

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gfosco @theimpostor @ajkr