Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing rocksdb_property_int_cf in C API #5249

Closed
dvdplm opened this issue Apr 25, 2019 · 2 comments
Closed

Missing rocksdb_property_int_cf in C API #5249

dvdplm opened this issue Apr 25, 2019 · 2 comments

Comments

@dvdplm
Copy link
Contributor

dvdplm commented Apr 25, 2019 •
edited
Loading

Currently the C API exposes rocksdb_property_value, rocksdb_property_int and rocksdb_property_value_cf, however there is no rocksdb_property_int_cf. This seems like an oversight and an easy fix? Code ref
@maysamyabandeh
Copy link
Contributor

Yeah it seems that rocksdb_property_int_cf is missing. Would you be interested in contributing a patch?

@dvdplm
Copy link
Contributor Author

dvdplm commented Apr 30, 2019

Would you be interested in contributing a patch?

Definitely. My C is weak so will need some review, but I'll have a stab at it. :)

@ordian ordian mentioned this issue Apr 30, 2019
Merged
dvdplm added a commit to dvdplm/rocksdb that referenced this issue Apr 30, 2019
@dvdplm
Add rocksdb_property_int_cf
8cbafee 
ref. facebook#5249
@dvdplm dvdplm mentioned this issue Apr 30, 2019
Closed
vagogte pushed a commit to vagogte/rocksdb that referenced this issue Jun 18, 2019
@dvdplm @facebook-github-bot
Add rocksdb_property_int_cf (facebook#5268)
b3c0b26 
Summary:
Adds the missing `rocksdb_property_int_cf` function to the C API to let consuming libraries avoid parsing strings.
Fixes facebook#5249
Pull Request resolved: facebook#5268

Differential Revision: D15149461

Pulled By: maysamyabandeh

fbshipit-source-id: e9fe5f1ad7c64066d921dba8473507269b51d331
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add rocksdb_property_int_cf dvdplm/rocksdb
2 participants
@dvdplm @maysamyabandeh