Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update db_bench description for unordered_write #6467

Closed
rbrasga opened this issue Feb 28, 2020 · 2 comments
Closed

Update db_bench description for unordered_write #6467

rbrasga opened this issue Feb 28, 2020 · 2 comments

Comments

@rbrasga
Copy link
Contributor

rbrasga commented Feb 28, 2020

Note: Please use Issues only for bug reports. For questions, discussions, feature requests, etc. post to dev group: https://groups.google.com/forum/#!forum/rocksdb or https://www.facebook.com/groups/rocksdb.dev

Expected behavior

DEFINE_bool(enable_pipelined_write, true,
            "Allow WAL and memtable writes to be pipelined");

DEFINE_bool(unordered_write, false,
            "**The writes to the main write queue in rocskdb goes through a different path**");

^ I'm not really sure what belongs there, even after reading: https://github.com/facebook/rocksdb/wiki/unordered_write

Actual behavior

DEFINE_bool(enable_pipelined_write, true,
            "Allow WAL and memtable writes to be pipelined");

DEFINE_bool(unordered_write, false,
            "Allow WAL and memtable writes to be pipelined");

^ Is the description really identical for both enable_pipelined_write and unordered_write?

Steps to reproduce the behavior

https://github.com/facebook/rocksdb/blob/master/tools/db_bench_tool.cc#L988

ltamasi added a commit to ltamasi/rocksdb that referenced this issue Mar 2, 2020
Summary:
As reported in facebook#6467, the
description of the `unordered_write` switch of `db_bench` was incorrect.

Test Plan:
`db_bench --help`
@ltamasi
Copy link
Contributor

ltamasi commented Mar 2, 2020

Thanks for reporting @rbrasga ! I've submitted a PR to fix this.

facebook-github-bot pushed a commit that referenced this issue Mar 2, 2020
Summary:
As reported in #6467, the
description of the `unordered_write` switch of `db_bench` was incorrect.
(Note: the new description is based on
https://rocksdb.org/blog/2019/08/15/unordered-write.html).
Pull Request resolved: #6476

Test Plan: `db_bench --help`

Differential Revision: D20200653

Pulled By: ltamasi

fbshipit-source-id: 4c3683fcfa6a069164167af5aaff9974a810c16a
@ltamasi ltamasi closed this as completed Mar 2, 2020
@rbrasga
Copy link
Contributor Author

rbrasga commented Mar 3, 2020

Great wording on the help! Thanks for the quick fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants