-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update db_bench description for unordered_write #6467
Comments
ltamasi
added a commit
to ltamasi/rocksdb
that referenced
this issue
Mar 2, 2020
Summary: As reported in facebook#6467, the description of the `unordered_write` switch of `db_bench` was incorrect. Test Plan: `db_bench --help`
Thanks for reporting @rbrasga ! I've submitted a PR to fix this. |
facebook-github-bot
pushed a commit
that referenced
this issue
Mar 2, 2020
Summary: As reported in #6467, the description of the `unordered_write` switch of `db_bench` was incorrect. (Note: the new description is based on https://rocksdb.org/blog/2019/08/15/unordered-write.html). Pull Request resolved: #6476 Test Plan: `db_bench --help` Differential Revision: D20200653 Pulled By: ltamasi fbshipit-source-id: 4c3683fcfa6a069164167af5aaff9974a810c16a
Great wording on the help! Thanks for the quick fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected behavior
^ I'm not really sure what belongs there, even after reading: https://github.com/facebook/rocksdb/wiki/unordered_write
Actual behavior
^ Is the description really identical for both enable_pipelined_write and unordered_write?
Steps to reproduce the behavior
https://github.com/facebook/rocksdb/blob/master/tools/db_bench_tool.cc#L988
The text was updated successfully, but these errors were encountered: